Skip to content

Adjust float format of ReleaseStat to avoid Excel Problem#924

Merged
fso42 merged 1 commit intomasterfrom
adjustRelStats
Oct 11, 2023
Merged

Adjust float format of ReleaseStat to avoid Excel Problem#924
fso42 merged 1 commit intomasterfrom
adjustRelStats

Conversation

@fso42
Copy link
Copy Markdown
Contributor

@fso42 fso42 commented Oct 8, 2023

Having only 2 decimals leads to Excel changing these fields to dates.... I know...

  • to avoid any confusion, it is set to 4 decimals now
  • clean getInput.py with black and remove unused parameters

@fso42 fso42 requested a review from awirb October 8, 2023 21:19
@fso42 fso42 self-assigned this Oct 8, 2023
@fso42 fso42 added enhancement New feature or request featureRequest ideas or functions that would be useful labels Oct 8, 2023
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Oct 8, 2023

Hello @fso42! Thanks for updating this PR.

Line 824:121: E501 line too long (127 > 120 characters)
Line 799:121: E501 line too long (129 > 120 characters)
Line 726:44: E231 missing whitespace after ','
Line 726:25: E231 missing whitespace after ','
Line 692:121: E501 line too long (135 > 120 characters)
Line 691:121: E501 line too long (167 > 120 characters)
Line 687:46: E231 missing whitespace after ','
Line 686:46: E231 missing whitespace after ','
Line 681:46: E231 missing whitespace after ','
Line 680:46: E231 missing whitespace after ','
Line 627:121: E501 line too long (127 > 120 characters)
Line 602:37: E201 whitespace after '('
Line 560:121: E501 line too long (125 > 120 characters)
Line 558:121: E501 line too long (150 > 120 characters)
Line 558:10: E117 over-indented
Line 558:10: E111 indentation is not a multiple of four
Line 471:121: E501 line too long (128 > 120 characters)
Line 400:121: E501 line too long (121 > 120 characters)
Line 316:80: E231 missing whitespace after ','
Line 233:34: E241 multiple spaces after ':'
Line 229:11: E271 multiple spaces after keyword
Line 199:33: E221 multiple spaces before operator
Line 188:121: E501 line too long (130 > 120 characters)
Line 188:47: E127 continuation line over-indented for visual indent

Line 269:5: E303 too many blank lines (2)
Line 240:6: E203 whitespace before ','
Line 132:20: E124 closing bracket does not match visual indentation
Line 100:1: E303 too many blank lines (4)

Line 777:1: E302 expected 2 blank lines, found 1
Line 724:121: E501 line too long (130 > 120 characters)
Line 322:121: E501 line too long (134 > 120 characters)
Line 321:121: E501 line too long (126 > 120 characters)
Line 321:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 273:121: E501 line too long (132 > 120 characters)
Line 78:121: E501 line too long (134 > 120 characters)
Line 59:28: E127 continuation line over-indented for visual indent

Line 404:46: E711 comparison to None should be 'if cond is not None:'
Line 401:33: E711 comparison to None should be 'if cond is not None:'
Line 391:43: E711 comparison to None should be 'if cond is None:'
Line 323:34: E711 comparison to None should be 'if cond is not None:'

Line 519:5: E303 too many blank lines (2)
Line 455:73: E231 missing whitespace after ','
Line 433:5: E303 too many blank lines (2)
Line 399:5: E303 too many blank lines (2)
Line 377:1: E303 too many blank lines (4)
Line 369:5: E303 too many blank lines (2)
Line 335:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 333:55: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 332:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 291:19: E222 multiple spaces after operator
Line 255:19: E222 multiple spaces after operator
Line 221:19: E222 multiple spaces after operator
Line 211:39: E711 comparison to None should be 'if cond is None:'
Line 207:37: E711 comparison to None should be 'if cond is None:'
Line 202:121: E501 line too long (149 > 120 characters)
Line 195:5: E303 too many blank lines (2)
Line 191:37: E225 missing whitespace around operator
Line 191:29: E225 missing whitespace around operator
Line 160:5: E303 too many blank lines (2)
Line 111:5: E303 too many blank lines (2)
Line 105:121: E501 line too long (143 > 120 characters)
Line 74:19: E222 multiple spaces after operator
Line 25:1: E302 expected 2 blank lines, found 1

Comment last updated at 2023-10-11 10:10:59 UTC

@fso42 fso42 added this to the Version 1.7 milestone Oct 8, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (711b23c) 73.73% compared to head (ea6618d) 73.79%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   73.73%   73.79%   +0.05%     
==========================================
  Files          63       63              
  Lines       14579    14572       -7     
==========================================
+ Hits        10750    10753       +3     
+ Misses       3829     3819      -10     
Files Coverage Δ
avaframe/ana3AIMEC/ana3AIMEC.py 76.75% <100.00%> (+0.12%) ⬆️
avaframe/ana4Stats/probAna.py 91.32% <100.00%> (ø)
avaframe/com1DFA/com1DFATools.py 92.30% <100.00%> (ø)
avaframe/com1DFA/deriveParameterSet.py 77.67% <100.00%> (ø)
avaframe/out3Plot/plotUtils.py 93.17% <66.66%> (ø)
avaframe/out3Plot/outAIMEC.py 80.00% <72.22%> (+0.19%) ⬆️
avaframe/in1Data/getInput.py 90.56% <90.84%> (+2.92%) ⬆️
avaframe/out3Plot/outParticlesAnalysis.py 37.70% <32.14%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

  - black format getInput and remove unused vars and parameters
  - remove empty filename option in getInput
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit ea6618d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 91.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.7% (0.0% change).

View more on Code Climate.

@fso42 fso42 merged commit 187dd36 into master Oct 11, 2023
@fso42 fso42 deleted the adjustRelStats branch October 11, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request featureRequest ideas or functions that would be useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants