This reverts commit c5f7108. Reason for revert: Causes Chromium WPT Tests to fail, preventing rolls. Sample failed run: https://ci.chromium.org/p/chromium/builders/try/linux-rel/511995? Sample logs: STDERR: # Fatal error in: ../../third_party/webrtc/pc/peer_connection.cc, line 575 STDERR: # last system error: 0 STDERR: # Check failed: (signaling_thread())->IsCurrent() STDERR: # Received signal 6 STDERR: #0 0x7f81d39e3de9 base::debug::CollectStackTrace() STDERR: #1 0x7f81d38f9ca3 base::debug::StackTrace::StackTrace() STDERR: #2 0x7f81d39e393b base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f81c9054140 (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f) STDERR: OpenNetLab#4 0x7f81c8d72db1 gsignal STDERR: OpenNetLab#5 0x7f81c8d5c537 abort STDERR: OpenNetLab#6 0x7f81c7344032 rtc::webrtc_checks_impl::FatalLog() STDERR: OpenNetLab#7 0x7f81c722e5c0 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: OpenNetLab#8 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: OpenNetLab#9 0x7f81c72d6e8e webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: OpenNetLab#10 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: OpenNetLab#11 0x7f81c71c6df3 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: OpenNetLab#12 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: OpenNetLab#13 0x7f81c73135bc rtc::OpenSSLStreamAdapter::ContinueSSL() STDERR: OpenNetLab#14 0x7f81c7312fd4 rtc::OpenSSLStreamAdapter::OnEvent() STDERR: OpenNetLab#15 0x7f81c71c30d9 cricket::StreamInterfaceChannel::OnPacketReceived() STDERR: OpenNetLab#16 0x7f81c71c640a cricket::DtlsTransport::OnReadPacket() STDERR: OpenNetLab#17 0x7f81c71cad61 cricket::P2PTransportChannel::OnReadPacket() STDERR: OpenNetLab#18 0x7f81c71bc90f cricket::Connection::OnReadPacket() STDERR: OpenNetLab#19 0x7f81c71e6255 cricket::UDPPort::HandleIncomingPacket() STDERR: OpenNetLab#20 0x7f81cd1f1bff blink::(anonymous namespace)::IpcPacketSocket::OnDataReceived() STDERR: OpenNetLab#21 0x7f81cd1f645d blink::P2PSocketClientImpl::DataReceived() STDERR: OpenNetLab#22 0x7f81cd50a16b network::mojom::blink::P2PSocketClientStubDispatch::Accept() STDERR: OpenNetLab#23 0x7f81d2b4f642 mojo::InterfaceEndpointClient::HandleValidatedMessage() STDERR: OpenNetLab#24 0x7f81d2b5304b mojo::MessageDispatcher::Accept() STDERR: OpenNetLab#25 0x7f81d2b50bb1 mojo::InterfaceEndpointClient::HandleIncomingMessage() STDERR: OpenNetLab#26 0x7f81d2b58a3a mojo::internal::MultiplexRouter::ProcessIncomingMessage() STDERR: OpenNetLab#27 0x7f81d2b57f7f mojo::internal::MultiplexRouter::Accept() STDERR: OpenNetLab#28 0x7f81d2b5304b mojo::MessageDispatcher::Accept() STDERR: OpenNetLab#29 0x7f81d2b48851 mojo::Connector::DispatchMessage() STDERR: OpenNetLab#30 0x7f81d2b492e7 mojo::Connector::ReadAllAvailableMessages() STDERR: OpenNetLab#31 0x7f81d2b490a3 mojo::Connector::OnHandleReadyInternal() STDERR: OpenNetLab#32 0x7f81d2b498f0 mojo::SimpleWatcher::DiscardReadyState() STDERR: OpenNetLab#33 0x7f81d2d0e67a mojo::SimpleWatcher::OnHandleReady() STDERR: OpenNetLab#34 0x7f81d2d0eb2b base::internal::Invoker<>::RunOnce() STDERR: OpenNetLab#35 0x7f81d397f85b base::TaskAnnotator::RunTask() STDERR: OpenNetLab#36 0x7f81d399a04c base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() STDERR: OpenNetLab#37 0x7f81d3999c78 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() STDERR: OpenNetLab#38 0x7f81d391fe64 base::MessagePumpDefault::Run() STDERR: OpenNetLab#39 0x7f81d399a8dc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() STDERR: OpenNetLab#40 0x7f81d395ae55 base::RunLoop::Run() STDERR: OpenNetLab#41 0x7f81d39c87f2 base::Thread::Run() Original change's description: > Reland "Replace sigslot usages with robocaller library." > > This is a reland of 40261c3 > > Note: Instead of changing the type of JsepTransportController->SignalSSLHandshakeError > added a new member with a different name and used it in webrtc code. > After this change do two more follow up CLs to completely remove the old code > from google3. > > Original change's description: > > Replace sigslot usages with robocaller library. > > > > - Replace all the top level signals from jsep_transport_controller. > > - There are still sigslot usages in this file so keep the inheritance > > and that is the reason for not having a binary size gain in this CL. > > > > Bug: webrtc:11943 > > Change-Id: I249d3b9710783aef70ba273e082ceeafe3056898 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185540 > > Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32321} > > Bug: webrtc:11943 > Change-Id: Ia07394ee395f94836f6b576c3a97d119a7678e1a > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186946 > Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32359} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,glahiru@webrtc.org Change-Id: I6bce1775d10758ac4a9d05b855f473dd70bd9815 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11943 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187487 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32372}

Cannot work in Release version #29

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions