Add Testing Documentation for Standalone Detailed Inspection#24
Closed
wangz539 wants to merge 6 commits intoOpenPBEE:mainfrom
Closed
Add Testing Documentation for Standalone Detailed Inspection#24wangz539 wants to merge 6 commits intoOpenPBEE:mainfrom
wangz539 wants to merge 6 commits intoOpenPBEE:mainfrom
Conversation
hgp297
requested changes
Mar 30, 2026
Collaborator
hgp297
left a comment
There was a problem hiding this comment.
Are there elements inside the ipynb that are critical to testing? e.g. Example code lines or images etc.?
If not, I would try to make this in Markdown/plain text as much as possible to make it out-of-the-box accessible.
Also, please try to remove commits 7590d04 and 9fdf134 from history. Recommended actions:
git checkout testing-doc
git fetch origin
git rebase -i origin/mainThen, in the rebase message, delete the pick lines that have 7590d04 and 9fdf134. save and exit this rebase message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the guide for users who need to validate their own ATC-138 MATLAB vs. Python results using the standalone comparison engine (
compare_runs.py) and explains the metrics used in ATC-138.Contents
ICSB,HaseltonRCMF_4story)Motivation
While the current repo includes integration tests, this doc provides more detailed instructions for users who need to validate their own models outside of the testing framework. The metrics we use for the published version are also explained.