Fix trajectory group duplication in gather_trajectory_groups #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The after_each callback in gather_trajectory_groups was causing group duplication by appending returned groups to the existing processed_groups list. This resulted in both the original groups and the groups returned by the callback being included in the final result. Fixed by resetting processed_groups to an empty list before collecting the after_each callback results, ensuring only the callback-returned groups are included in the final output. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-46ce9369-cd67-44ca-b963-75c14498132e
Contributor
Author
|
This was a bug that I recently (inadvertently) introduced on main, so I'm just going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the
after_eachcallback ingather_trajectory_groupswas causing group duplication by appending returned groups to the existing processed_groups list.Problem
When using
gather_trajectory_groupswith anafter_eachcallback, the function was duplicating trajectory groups. The callback would return the same groups it received (possibly after processing), but these returned groups were being appended to the existingprocessed_groupslist rather than replacing it.This resulted in:
groups_per_step)Solution
Reset
processed_groupsto an empty list before collecting theafter_eachcallback results, ensuring only the callback-returned groups are included in the final output.Testing
Verified that model 237 in art-e now correctly shows 12 groups submitted instead of the previous 20-24.