fix: resolve ruler function/module name collision in art.rewards (#339)#660
Open
robrui wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix: resolve ruler function/module name collision in art.rewards (#339)#660robrui wants to merge 1 commit intoOpenPipe:mainfrom
robrui wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
The import 'from .ruler import ruler' in art.rewards.__init__ shadowed the art.rewards.ruler module name with the ruler() function, making the module's constants (DEFAULT_RUBRIC, Response, TrajectoryScore, etc.) inaccessible via art.rewards.ruler. Changed to 'from . import ruler as _ruler' pattern, then aliased ruler and ruler_score_group at the module level. The _ruler name keeps the module accessible for those who need DEFAULT_RUBRIC or other module-level attributes. Fixes OpenPipe#339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The import
from .ruler import rulerinart.rewards.__init__shadowed theart.rewards.rulermodule name with theruler()function, making the module-level constants (DEFAULT_RUBRIC,Response,TrajectoryScore, etc.) inaccessible viaimport art.rewards.rulerorfrom art.rewards import ruler as art_ruler.Attempting to access
DEFAULT_RUBRICthrough the module raised:Fix
Changed the import pattern from:
to:
This keeps both the module accessible (via
_rulerinternals) and the existing public API (art.rewards.ruler(),art.rewards.ruler_score_group()) intact — no breaking changes.Fixes #339