Fix Unsloth autocast dtype for bf16 models#663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PipelineTrainer + LocalBackend can load bf16 base models like Llama 3.1 in 16-bit mode while
ACCELERATE_MIXED_PRECISIONis unset. We were defaulting the Unsloth logprob path to fp16 in that case, which can hitHalfvsBFloat16matmul mismatches.This keeps explicit mixed-precision settings authoritative, but when the env var is unset, infers the autocast dtype from the loaded model parameters. Unknown mixed-precision/model dtype states fail early instead of silently falling through.
Validation
.venv/bin/pytest tests/unit/test_unsloth_autocast_dtype.py -qload_in_4bit=False,load_in_16bit=True,ACCELERATE_MIXED_PRECISIONunset; reached step 2 and reloaded adapters for steps 1 and 2.