frontend: Disconnect dbus signals to avoid use-after-free#90
Merged
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom Mar 12, 2026
Merged
frontend: Disconnect dbus signals to avoid use-after-free#90tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
Conversation
cpdbDeletePrinterObj() free's the struct passed to the GDBus signal handlers without making sure that these are not going to be called anymore. g_dbus_connection_close_sync() is not enough because there may have bene signals already received and awaiting to be dispatched in the next iteration of the mainloop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpdbDeletePrinterObj() free's the struct passed to the GDBus signal handlers without making sure that these are not going to be called anymore.
g_dbus_connection_close_sync() is not enough because there may have bene signals already received and awaiting to be dispatched in the next iteration of the mainloop.