Set MX to 0 for foo2zjs/foo2xqx HP printers#8
Open
Icenowy wants to merge 2 commits into
Open
Conversation
The proprietary blob of HPLIP seems to always set MX to 0. Set the MX to 0 in foo2xqx, which supports only HP printers, and is what currently used by LaserJet Pro M1130/M1210 MFP series. Without this change garbled content was seen on my LaserJet Pro M1136 MFP. Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
The proprietary blob of HPLIP seems to always set MX to 0, and foo2zjs currently sets MX to 0 for z2/z3 printers. Set MX to 0 for z1 printers too. Tested on my LaserJet Pro M1136 MFP, which accepts XQX by default, but can be switched to ZJS by emitting a `PJL ENTER LANGUAGE` clause (HPLIP emits ZJS for this printer): with MX = 16 sometimes content is garbled, but with MX = 0 the same content prints okay. Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6 .