Fallback to using LC_CTYPE if LC_MESSAGES is empty and fix _language use#108
Merged
zdohnal merged 1 commit intoOpenPrinting:masterfrom Jun 26, 2018
Merged
Fallback to using LC_CTYPE if LC_MESSAGES is empty and fix _language use#108zdohnal merged 1 commit intoOpenPrinting:masterfrom
zdohnal merged 1 commit intoOpenPrinting:masterfrom
Conversation
On openSUSE, LC_MESSAGES is not set by default, so fallback to LC_CTYPE in that case. Also, self._language is not a list (unlike in other classes) but the language itself, so if we get the first element, we would be getting the first letter, not the language.
Member
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On openSUSE, LC_MESSAGES is not set by default, so fallback to LC_CTYPE in
that case.
Also, self._language is not a list (unlike in other classes) but the language
itself, so if we get the first element, we would be getting the first letter,
not the language.