Fix problems with saving of advanced settings#128
Merged
zdohnal merged 2 commits intoOpenPrinting:masterfrom Jan 14, 2019
TomasKorbar:changes
Merged
Fix problems with saving of advanced settings#128zdohnal merged 2 commits intoOpenPrinting:masterfrom TomasKorbar:changes
zdohnal merged 2 commits intoOpenPrinting:masterfrom
TomasKorbar:changes
Conversation
After reading from stream we must return again to line 0 if we want to read file again
in python3 os.read returns byte object not a string which caused writing loop to be endless by adding b'' comparison we hold compatibility both with python2 and python3
Member
|
LGTM, thank you for the patch! |
|
Thank you, this was a long standing bug 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
These commits Fix #37
For more information please see commit messages.