adds Hovers WorldVisualOffset to muzzle calculations #21252
Conversation
| @@ -110,6 +111,8 @@ public class Armament : PausableConditionalTrait<ArmamentInfo>, ITick | |||
| public readonly WeaponInfo Weapon; | |||
| public readonly Barrel[] Barrels; | |||
| Turreted turret; | |||
| Hovers hovers; | |||
There was a problem hiding this comment.
it feels a bit weird to hardcode Hovers here, but I suppose it's fine
There was a problem hiding this comment.
Well it could be implemented via some interface IModifiesMuzzleOffset or something but since it's only trait that does that for now I suppose it's overkill.
There was a problem hiding this comment.
Wouldn't things like slopes and tilting from explosions also need to modify the offset?
Rebasing with |
CDVoidwalker
force-pushed
the
armament-respects-hovers
branch
from
df19a31
to
8cb2012
Compare
CDVoidwalker
force-pushed
the
armament-respects-hovers
branch
from
8cb2012
to
20dd438
Compare
Got used to working on non forked repo at work so I forgot to update my fork branches. Rebased on upstream bleed and squashed. @abcdefg30 Slopes already modify the offsets, don't know about tilting from explosions. |
This is a simple change that makes muzzle take in current world offset from hovers trait, if one is present. This way units such as hover MRLS have accurate offset positions.