Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't import RCT1 Deluxe from Steam #10228

Closed
nate2014jatc opened this issue Nov 13, 2019 · 5 comments
Closed

Can't import RCT1 Deluxe from Steam #10228

nate2014jatc opened this issue Nov 13, 2019 · 5 comments
Assignees
@Gymnasiast
Labels
investigate Not sure what the problem is yet. rct1 Relates to RollerCoaster Tycoon 1.

Comments

@nate2014jatc
Copy link

OS: [Linux Mint 19]
Version: [0.2.4]
Commit/Build: [d64535875]

I am having issues importing from the Steam version of RCT1: Deluxe.
I don't see a css17.dat or mp.dat, did something in the Steam version change?
Seems related to #7022 and #5359

  • [?] Reproducible in RCT2 (vanilla)?
  • [?] Specific to multiplayer?

Steps to reproduce:

  1. Attempt to import RCT1 files through GUI on Main Menu Screen.
  2. Navigate file browser to /media/nate/BulkStorage/SteamLibrary/steamapps/common/RollerCoaster Tycoon Deluxe/, /media/nate/BulkStorage/SteamLibrary/steamapps/common/RollerCoaster Tycoon Deluxe/RCTdeluxe_install, and I tried /media/nate/BulkStorage/SteamLibrary/steamapps/common/RollerCoaster Tycoon Deluxe/RCTdeluxe_install/Data just for giggles.
  3. Receive error "Please select a valid RCT1 directory"

Dump file

Not Present
Screenshots / Video:

image

Save game:

N/A
@Krutonium
Copy link
Member

I confirmed this on my end, and glancing at the code it looks like it should work (Correct file capitalization and everything), but it refuses as shown above. That being said, if you edit ~/.config/OpenRCT2/config.ini to have the path to your RCT1 install, it works perfectly fine.

@nate2014jatc
Copy link
Author

Fascinating.
Which directory did you use, the Steam one or the Installer one?

@Krutonium
Copy link
Member

Steam

@Gymnasiast
Copy link
Member

It is still a bug if the GUI does not allow you to select that folder. I'll reopen this to track the GUI bug.

@Gymnasiast Gymnasiast reopened this Nov 13, 2019
@Gymnasiast Gymnasiast added the investigate Not sure what the problem is yet. label Nov 13, 2019
@Gymnasiast Gymnasiast self-assigned this Nov 13, 2019
@Gymnasiast Gymnasiast added the rct1 Relates to RollerCoaster Tycoon 1. label Nov 13, 2019
@catb0t
Copy link

catb0t commented Nov 17, 2019

The error in the console is WARNING[../src/openrct2/util/Util.cpp:417 (safe_strcpy)]: Truncating string "/home/c" to 8 bytes.. The path does not exist because safe_strcpy truncated the string, probably because the string length it was given was 8 or defaulted to 8 because of a buggy error condition.

IntelOrca added a commit to IntelOrca/OpenRCT2 that referenced this issue Nov 18, 2019
@IntelOrca
Fix OpenRCT2#10228: Can't import RCT1 Deluxe from Steam
16186d5 
Use size of buffer rather than the size of a pointer which would always return 4 or 8 for the buffer size.
scrapes pushed a commit to scrapes/OpenRCT2 that referenced this issue Dec 15, 2019
@IntelOrca
Fix OpenRCT2#10228: Can't import RCT1 Deluxe from Steam (OpenRCT2#10260)
21a88bc 
Use size of buffer rather than the size of a pointer which would always return 4 or 8 for the buffer size.
MichaelJBerk pushed a commit to MichaelJBerk/OpenRCT2 that referenced this issue Dec 18, 2019
@IntelOrca @MichaelJBerk
Fix OpenRCT2#10228: Can't import RCT1 Deluxe from Steam (OpenRCT2#10260)
7a8c6ff 
Use size of buffer rather than the size of a pointer which would always return 4 or 8 for the buffer size.
janisozaur added a commit that referenced this issue Mar 24, 2020
@janisozaur
Release 0.2.5
4f6e77e 
- Feature: [#3154] Use a random title sequence each time it is shown.
- Feature: [#6553] Android version now runs in full screen.
- Feature: [#7865] Transport rides can now be synchronised.
- Feature: [#9073] Shortcut keys for the Tile Inspector.
- Feature: [#10305] Add two shortcuts for increasing and decreasing the scaling factor.
- Feature: [#10189] Make Track Designs work in multiplayer.
- Feature: [#10357] Added window for scenery scatter tool, allowing for area and density selection.
- Feature: [#10637] Console command to remove all floating objects.
- Change: [#1164] Use available translations for shortcut key bindings.
- Change: [#10997] Speed is automatically reset to normal upon scenario completion.
- Fix: [#2485] Hide Vertical Faces not applied to the edges of water.
- Fix: [#5249] No collision detection when building ride entrance at heights > 85.5m.
- Fix: [#6766] Changelog window doesn't open on some platforms.
- Fix: [#7784] Vehicle tab takes 1st car colour instead of tab_vehicle's colour.
- Fix: [#7854] Cannot build a custom spiral roller coaster design.
- Fix: [#7854] Empty entries in spiral roller coaster designs list.
- Fix: [#8151] Game freezes upon demolishing mazes at odd heights.
- Fix: [#8875] RCT1 competition scenarios are classified incorrectly.
- Fix: [#10176] Mistake in the sprite for the land tool's 6x6 grid.
- Fix: [#10196] Doors unable to be placed at end of track corners.
- Fix: [#10228] Can't import RCT1 Deluxe from Steam.
- Fix: [#10313] Path furniture can be placed on level crossings.
- Fix: [#10325] Crash when banners have no text.
- Fix: [#10376] No ratings generated when a shop and track intersect.
- Fix: [#10420] Money effect causing false positive desync.
- Fix: [#10477] Large Scenery cannot be placed higher using SHIFT.
- Fix: [#10489] Hosts last player action not being synchronized.
- Fix: [#10543] Secondary shop item prices are not imported correctly from RCT1 saves.
- Fix: [#10547] RCT1 parks have too many rides available.
- Fix: [#10587] Update last action coordinates on correct player.
- Fix: [#10631] Game bugs out and crashes if you get too many stations via copying stations with the tile inspector.
- Fix: [#10662] Duck cheat tooltips look odd and do not explain anything.
- Fix: [#10694] The lift hill speed of the flying roller coaster cannot be changed (original bug).
- Fix: [#10705] Apply multithreaded rendering to all viewports.
- Fix: [#10739] Mountain tool overlay for even-numbered selections.
- Fix: [#10752] Mute button state not correctly set at startup.
- Fix: [#10822] Can place too many peep spawns.
- Fix: [#10898] Banner text has an offset in tile inspector window.
- Fix: [#10904] RCT1/LL-scenarios with red water won't open.
- Fix: [#10941] The Clear Scenery tool gives refunds for ghost elements.
- Fix: [#10963] Light effects are drawn off-centre in some rotations.
- Fix: [#10993] Bottom toolbar not refreshing when a guest leaves the park.
- Fix: [#11001] Rides list does not use natural sorting.
- Fix: [objects#54] Stage Coach cars are not considered covered by the game.
- Fix: [objects#56] Handymen cut grass incorrectly.
- Improved: [#682] The staff patrol area is now drawn on the water, instead of on the surface under water.
- Improved: [#10858] Added horizontal grid lines to finance charts.
- Improved: [#10884] Added y-axes and labels to park window charts.
- Improved: [#10970] Introduced optional light effects for vehicles at night.
- Removed: [#6898] LOADMM and LOADRCT1 title sequence commands (use LOADSC instead).
XplosiveLugnut pushed a commit to XplosiveLugnut/OpenRCT2 that referenced this issue Apr 27, 2020
@IntelOrca
Fix OpenRCT2#10228: Can't import RCT1 Deluxe from Steam (OpenRCT2#10260)
eb2cd96 
Use size of buffer rather than the size of a pointer which would always return 4 or 8 for the buffer size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gymnasiast Gymnasiast

Labels
investigate Not sure what the problem is yet. rct1 Relates to RollerCoaster Tycoon 1.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gymnasiast @catb0t @Krutonium @nate2014jatc