Changelog window won't open

[mrtnptrs]

OS: Windows 10 and Android 7.0 (Samsung Galaxy S8+)
Version: 0.1.2
Commit/Build: 33d0fa9

If you go to the about OpenRCT2 window and try to open the Changelog-window, it doesn't open that window.

[AaronVanGeffen]

Is it even shipped in the Android build?

[mrtnptrs]

I don't know, but it also won't open when using Windows 10, as I said earlier above (I tested that of course as I suspected first it was an Android-only bug, but it isn't.)

[AaronVanGeffen]

Hmm. It used to open for me if it were in a doc subdirectory in the same directory as the binary. That is no longer the case. I'm guessing this regression relates to the recent changes to the platform code, then.

[AaronVanGeffen]

As far as I can tell, Windows and macOS builds ship with the changelog file in the place I would expect them to.

Is this still an issue on Windows for you, @mrtnptrs?

[mrtnptrs]

Yes, the automated Windows build ships with the changelog file (macOS not tested). The problem is that is is in the main directory (with the executable); OpenRCT2 seems to only be able to find it when it is in the data-folder. As soon as you place the changelog.txt file in the data folder, the changelog screen works again. So, two options to fix this: making OpenRCT2 recognize the changelog.txt file from the main directory or place the changelog.txt file in the data-directory.

The line causing this:

OpenRCT2/src/openrct2/PlatformEnvironment.cpp

Line 95 in c8f822e

return DIRBASE::DOCUMENTATION;

Edit: give me a few minutes, I think I can fix this.

[AaronVanGeffen]

It certainly used to be able to find the file in the same directory as the running executable. Sounds like a regression.

[mrtnptrs]

It certainly used to be able to find the file in the same directory as the running executable. Sounds like a regression.

Yeah, I think I can fix it. Compiling the fix at my end now to start testing.

Edit: testing the fix now, but I see the changelog.txt file isn't in the bin-folder when you compile OpenRCT2 yourself with Visual Studio (2019.)

[mrtnptrs]

I thought editing this line:

OpenRCT2/src/openrct2/PlatformEnvironment.cpp

Line 95 in c8f822e

return DIRBASE::DOCUMENTATION;

to return DIRBASE::OPENRCT2; (so, pointing it from the data-folder to the main OPENRCT2-folder) would fix it, but strangely it doesn't. It still only recognizes the changelog.txt file only when it is in the data-folder.... Why?

Edit: If I look at this line, I would expect my fix to work, but it doesn't weirdly:

OpenRCT2/src/openrct2-ui/windows/Changelog.cpp

Line 209 in 83b1d1f

return env->GetFilePath(PATHID::CHANGELOG);

[ZehMatt]

Maybe you could log the file path returned to see if its actually correct? Or simply build the whole thing with the Debug configuration and step over the code to see how it builds the path.