fix OpenRCT2#19398 invisible paths still cause random sprites to appear#235
Merged
duncanspumpkin merged 2 commits intoOpenRCT2:masterfrom Mar 12, 2023
Merged
Conversation
Broxzier
reviewed
Mar 6, 2023
objects/official/footpath_surface/openrct2.footpath_surface.invisible.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
Broxzier
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix OpenRCT2/OpenRCT2#19398
By definition a path object must have 52 images. One image is the thumbnail, 51 images are for the 51 possible combinations:
https://github.com/OpenRCT2/OpenRCT2/blob/dd624f9bff4ce116a40f121507a426b484cb9412/src/openrct2/paint/tile_element/Paint.Path.cpp#L58-L67
This object currently has 51 images, not 52. I do not know why this bug does not affect certain parks - it should affect all parks.