fix(rtmp_bridge): preserve ConnState on connect, deactivate on stream switch

[cursor]

Bug scan: rtmp_bridge (2026-07-02)

Critical bugs fixed

1. on_connect() wiped authorized publisher state

   • When a client completes handshake + publish in a single poll() tick, authorize_publish() runs before the poll-loop on_connect().
   • on_connect() used HashMap::insert, replacing the ConnState that already held the publisher row.
   • Impact: legitimate publishers rejected as unauthorized; ghost active=1 publisher row blocks future publishes to that stream.

2. Stream switch left ghost active DB rows

   • authorize_publish() / on_play() overwrote in-memory session state without deactivating the prior publisher/player row when the same TCP connection issued a second publish/play to a different stream.
   • Impact: stale active rows in stats/API; publisher slot leak on stream switch.

Fix

• on_connect() now uses entry().or_insert_with() to preserve existing ConnState.
• authorize_publish() / on_play() deactivate any prior session row on the same connection before acquiring a new one.

Tests

• on_connect_preserves_prior_authorize_publish_state
• authorize_publish_switching_streams_deactivates_prior_publisher
• on_play_switching_streams_deactivates_prior_player

All 13 rtmp_bridge unit tests pass.

  

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 47a69502-6cdb-4559-8b90-ffaab615ebc2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/bug-scanning-automation-3159

---

_{Comment @coderabbitai help to get the list of available commands.}