front: switch package type to module #10671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/module
branch
5 times, most recently
from
e5c2185 to
3f73aa6
Compare
emersion
force-pushed
the
emr/module
branch
17 times, most recently
from
fb765b4 to
aaf9e0f
Compare
SharglutDev
reviewed
Feb 6, 2025
SharglutDev
approved these changes
Feb 6, 2025
Maymanaf
reviewed
Feb 6, 2025
Contributor
Maymanaf
left a comment
Maymanaf
left a comment
There was a problem hiding this comment.
Good job !
However, the test appears to be flaky when using the pdfjs-dist library
require() cannot be used with packages marked as modules. We want to switch osrd to modules. Signed-off-by: Simon Ser <contact@emersion.fr>
We'll soon change the default to ESM. rtk-query requires config files to be CJS: reduxjs/redux-toolkit#2437 (comment) Signed-off-by: Simon Ser <contact@emersion.fr>
JSON imports cause issues with ESM. Signed-off-by: Simon Ser <contact@emersion.fr>
When directly importing a file from a CommonJS package, the file extension needs to be specified: https://nodejs.org/api/esm.html#esm_mandatory_file_extensions Signed-off-by: Simon Ser <contact@emersion.fr>
pdf-parse is not maintained anymore and is causing issues with newer standards: https://gitlab.com/autokent/pdf-parse/-/issues/38 Instead, directly use the official pdf.js package. We need to fiddle with transform[5] which indicates when a line break happens: https://stackoverflow.com/questions/54645206/pdfjs-get-raw-text-from-pdf-with-correct-newline-withespace The legacy build needs to be used in Nodejs environments: https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support Signed-off-by: Simon Ser <contact@emersion.fr>
Modules are the standard way to handle JavaScript imports. osrd-ui already uses modules everywhere, but osrd is lagging behind. Modernize our configuration to use ECMAScript Modules instead of legacy CommonJS. Signed-off-by: Simon Ser <contact@emersion.fr>
We now use ESM everywhere, we don't need to resolve CommonJS nor AMD anymore. The rule is enabled by default by import/recommended, so dropping the line just uses the defaults instead of custom options. Signed-off-by: Simon Ser <contact@emersion.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Modules are the standard way to handle JavaScript imports. osrd-ui already uses modules everywhere, but osrd is lagging behind.
Modernize our configuration to use ECMAScript Modules instead of legacy CommonJS.