Add paced trains new endpoints #10971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:front
younesschrifi
force-pushed
the
yci/create-paced-trains-model
branch
2 times, most recently
from
ee0f31f to
883fc16
Compare
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
from
0a4aed7 to
4c9f851
Compare
github-actions
bot
removed
the
area:integration-tests
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10971 +/- ##
==========================================
- Coverage 81.63% 80.67% -0.97%
==========================================
Files 1098 1098
Lines 110595 111785 +1190
Branches 742 744 +2
==========================================
- Hits 90280 90177 -103
- Misses 20273 21565 +1292
- Partials 42 43 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
younesschrifi
force-pushed
the
yci/create-paced-trains-model
branch
from
883fc16 to
abd0bea
Compare
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
2 times, most recently
from
d59e418 to
8ec759e
Compare
younesschrifi
force-pushed
the
yci/create-paced-trains-model
branch
from
abd0bea to
e1d59ac
Compare
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
from
8ec759e to
0f547c8
Compare
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
2 times, most recently
from
dcefc0e to
5a2ad40
Compare
flomonster
approved these changes
Feb 27, 2025
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
3 times, most recently
from
b236c93 to
72256fd
Compare
Wadjetz
approved these changes
Feb 28, 2025
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
from
72256fd to
4a6ca0f
Compare
leovalais
approved these changes
Mar 3, 2025
Contributor
leovalais
left a comment
leovalais
left a comment
There was a problem hiding this comment.
LGTM, but I still feel like the module tree could be improved to avoid visibility issues (and thus making everything pub) and weirdly placed definitions. How about scheduling a point with @flomonster to talk about that after this PR is merged in order not to block frontend development?
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
from
4a6ca0f to
df65a8d
Compare
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
younesschrifi
force-pushed
the
yci/create-new-endpoints
branch
from
df65a8d to
d09d802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare paced train endpoints for frontend.
The endpoints will be implemented soon.
Part of https://github.com/osrd-project/osrd-confidential/issues/779