Skip to content

Conversation

@eckter
Copy link
Contributor

@eckter eckter commented Mar 20, 2025

Well that was a massive bug considering how sneaky it is. It's in BlockAvailability (a class that's mocked in most tests), and Offset<Path> == Offset<TravelledPath> in most test cases.

InfraExplorerWithEnvelope.getSimulatedLength() returned a Length<Path>, when it should really be TravelledPath.

I'd add a unit test with stops in BlockAvailabilityTests, but that would massively conflict with the other pending PRs.

Fix some (most?) cases of #11121.

@github-actions github-actions bot added the area:core Work on Core Service label Mar 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (5644ec8) to head (b4caa19).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11210   +/-   ##
=======================================
  Coverage   81.42%   81.43%           
=======================================
  Files        1124     1124           
  Lines      113152   113153    +1     
  Branches      758      758           
=======================================
+ Hits        92139    92141    +2     
+ Misses      20958    20957    -1     
  Partials       55       55           
Flag Coverage Δ
editoast 72.47% <ø> (+<0.01%) ⬆️
front 89.96% <ø> (+<0.01%) ⬆️
gateway 2.48% <ø> (ø)
osrdyne 8.00% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eckter eckter force-pushed the ech/fix-conflict-offsets branch from 841c0e7 to 4ac834d Compare March 20, 2025 16:47
@eckter eckter requested a review from Erashin March 20, 2025 16:48
@eckter eckter marked this pull request as ready for review March 20, 2025 16:48
@eckter eckter requested a review from a team as a code owner March 20, 2025 16:48
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that must have been fun to debug. Good job, this is huge!
For the test, I'm fine with merging this as is, putting said test in an issue and doing it once the other PRs are merged.

@eckter eckter force-pushed the ech/fix-conflict-offsets branch from 4ac834d to cb1ebc5 Compare March 21, 2025 09:55
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bugfix!

Apart from the naming, I guess my first 2 comments can (should?) be tracked a sibling issues of #10595.
If agreeing on the usefulness of suggestions, I can create issues.

@eckter eckter force-pushed the ech/fix-conflict-offsets branch from 6698feb to 977f646 Compare March 25, 2025 08:27
@eckter eckter linked an issue Mar 25, 2025 that may be closed by this pull request
@eckter eckter enabled auto-merge March 25, 2025 08:35
@eckter eckter force-pushed the ech/fix-conflict-offsets branch 2 times, most recently from 18c0fb6 to ca7af9e Compare March 25, 2025 14:03
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
@eckter eckter force-pushed the ech/fix-conflict-offsets branch from ca7af9e to 9ba6aab Compare March 25, 2025 14:16
This early return relied on the fact that the nodes
with lowest total time were processed first, which
isn't true anymore

Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
@eckter eckter added this pull request to the merge queue Mar 26, 2025
@eckter eckter removed this pull request from the merge queue due to a manual request Mar 26, 2025
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 If you have a unit test for the second commit's bug, it's nice to embed (we can consider that e2e tests are enough, I guess).

@eckter eckter added this pull request to the merge queue Mar 26, 2025
Merged via the queue into dev with commit cade990 Mar 26, 2025
27 checks passed
@eckter eckter deleted the ech/fix-conflict-offsets branch March 26, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Work on Core Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lmr: technical problem error on MAC-LYD-VCE

5 participants