-
Notifications
You must be signed in to change notification settings - Fork 64
Fix gateway mock provider #11215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gateway mock provider #11215
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11215 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 1124 1124
Lines 113163 113152 -11
Branches 758 758
=======================================
Hits 92139 92139
+ Misses 20969 20958 -11
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Khoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
89fb796 to
ce48858
Compare
|
Tested it. |
192e143 to
42928ba
Compare
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
42928ba to
c911486
Compare
This PR cleans the
x-remote-user-identityandx-remote-user-namewhen using the mock provider.Before:
mock.identity/Example UserAfter:
mock/mockedI also fixed the username that was not being passed to editoast. As the mock provider was registered as both a session provider and an identity provider, it always matched the identity (which doesn't provide the username).
To solve this problem, I removed the mock provider's identity implementation. By doing so, the
require_loginfield became unused, so I deleted it.