Skip to content

Conversation

@kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Apr 30, 2025

Implement the header for the new Scenario view.see mock-up.

This PR includes only the UI; it adds no interactions.

@kmer2016 kmer2016 requested a review from a team as a code owner April 30, 2025 11:29
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Apr 30, 2025
@kmer2016 kmer2016 force-pushed the cnh/front/new-scenario-view-header branch 2 times, most recently from 0b4c140 to 939f8ee Compare April 30, 2025 11:47
@kmer2016 kmer2016 self-assigned this Apr 30, 2025
@kmer2016 kmer2016 requested review from clarani and theocrsb April 30, 2025 11:52
@kmer2016 kmer2016 force-pushed the cnh/front/new-scenario-view-header branch 2 times, most recently from 3ce0f84 to 0328673 Compare May 2, 2025 19:00
@SharglutDev SharglutDev requested review from RomainValls and removed request for theocrsb May 6, 2025 09:09
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, nice to see the first stone of the new UI :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thanks ! (you can close the last comment when indentation is fixed)

@SharglutDev
Copy link
Contributor

If I'm not mistaken, the plan was to integrate these new interfaces directly inside the current one and not used a secondary path url ?

@kmer2016
Copy link
Contributor Author

kmer2016 commented May 9, 2025

If I'm not mistaken, the plan was to integrate these new interfaces directly inside the current one and not used a secondary path url ?

Yes, that’s the long-term goal. But first, we’ll build the structure of the UI on the second URL. Once the structure is ready and we need to integrate the components from the current version, we’ll do that directly on the current URL.

@kmer2016 kmer2016 force-pushed the cnh/front/new-scenario-view-header branch 2 times, most recently from 55b576c to 385c46d Compare May 13, 2025 14:15
Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016 kmer2016 force-pushed the cnh/front/new-scenario-view-header branch from 385c46d to 81f42ad Compare May 13, 2025 14:28
@kmer2016 kmer2016 enabled auto-merge May 13, 2025 14:29
@kmer2016 kmer2016 added this pull request to the merge queue May 13, 2025
Merged via the queue into dev with commit cec38c2 May 13, 2025
27 checks passed
@kmer2016 kmer2016 deleted the cnh/front/new-scenario-view-header branch May 13, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants