editoast: replace `track_reference` with `local_track_name` by hamz2a · Pull Request #14807 · OpenRailAssociation/osrd

hamz2a · 2026-01-20T09:09:19Z

Remove the TrackReference enum that allowed filtering by either track ID or track name. Now only filter by local_track_name directly.
This simplifies the filtering logic by moving it directly into OperationalPoint instead of having a separate filter step.

Changes:

Remove TrackReference enum
Replace track_reference field with local_track_name
Add track_offsets_matching_local_name method to OperationalPoint
Remove track_reference_filter method from PathItemCache
Add get_name_by_track helper method to PathItemCache
Update all usages across path items, pathfinding, tests, and front.

github-actions · 2026-01-20T09:09:42Z

⚠️ API changes

This Pull Request introduces some changes in the API:

please own it: notify or even prepare dedicated PR(s) to consumer projects

Changes in Schemas

Dear @hamz2a, please ensure the following:

changes should match in osrd_schemas and editoast schemas
the RailJSON version in osrd_schemas::infra.py and editoast schemas::infra::railjson.rs should match and be bumped on any change of infra schemas (same goes for rolling-stock between osrd_schemas::rolling_stock.py and editoast schemas::rolling_stock.rs)
the version of the Python package in osrd_schemas::pyproject.toml should be bumped on any change

flomonster

Thanks for this PR, we need a migration to adapt paced trains (model + exceptions).
I will need further testing afterwards.

Khoyo

Thanks for the clear commit message!

hamz2a · 2026-01-20T14:56:36Z

we need a migration to adapt paced trains (model + exceptions).
@flomonster

Done

Castavo

I'm surprised that with the inlining of NonBlankString in the openAPI we still get a LocalTrackName root model in models.py

Besides that, LGTM on models part.

Could you make sure that the changes are handled in our data pipelines too ?

SharglutDev

Thanks for the PR !

Nope

SarahBellaha

Lgtm

SharglutDev

Lgtm and tested ✅

Remove the TrackReference enum that allowed filtering by either track ID or track name. Now only filter by local_track_name directly. This simplifies the filtering logic by moving it directly into OperationalPoint instead of having a separate filter step. Signed-off-by: hamz2a <atrari.hamza@gmail.com>

Signed-off-by: hamz2a <atrari.hamza@gmail.com>

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

hamz2a requested review from a team as code owners January 20, 2026 09:09

hamz2a requested a review from Castavo January 20, 2026 09:09

github-actions Bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Jan 20, 2026

hamz2a changed the title ~~editoast: replace track_reference with local_track_name~~ editoast: replace track_reference with local_track_name Jan 20, 2026

hamz2a moved this to Awaiting merge in Board PI 18 Jan 20, 2026

hamz2a added this to Board PI 18 Jan 20, 2026

hamz2a self-assigned this Jan 20, 2026

hamz2a requested a review from flomonster January 20, 2026 09:11

hamz2a force-pushed the hai/editoast-track-reference-filter branch from e70b643 to 6674fd9 Compare January 20, 2026 09:16

hamz2a changed the title ~~editoast: replace track_reference with local_track_name~~ editoast: replace track_reference with local_track_name Jan 20, 2026

hamz2a force-pushed the hai/editoast-track-reference-filter branch 3 times, most recently from c1ad278 to 14223d6 Compare January 20, 2026 10:26

flomonster previously requested changes Jan 20, 2026

View reviewed changes

flomonster mentioned this pull request Jan 20, 2026

front: use local track name #14780

Merged

4 tasks

Castavo reviewed Jan 20, 2026

View reviewed changes

Comment thread editoast/schemas/src/train_schedule/path_item.rs

Khoyo reviewed Jan 20, 2026

View reviewed changes

hamz2a requested a review from flomonster January 20, 2026 14:57

hamz2a force-pushed the hai/editoast-track-reference-filter branch from e1a8d58 to 6e20b04 Compare January 20, 2026 15:03

hamz2a requested review from Castavo and Khoyo January 20, 2026 15:32

Castavo approved these changes Jan 21, 2026

View reviewed changes

SharglutDev reviewed Jan 28, 2026

View reviewed changes

Comment thread ...es/views/Scenario/components/ManageTimetableItem/ManageTimetableItemMap/AddPathStepPopup.tsx

Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts Outdated

Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts

shenriotpro reviewed Jan 28, 2026

View reviewed changes

Comment thread front/src/common/Map/Layers/InfraObjectLayers/OperationalPoints.tsx

shenriotpro approved these changes Jan 28, 2026

View reviewed changes

Uriel-Sautron force-pushed the hai/editoast-track-reference-filter branch from 69d300b to 089b066 Compare January 29, 2026 08:40

flomonster removed the request for review from Khoyo January 29, 2026 10:37

shenriotpro removed request for emersion and maelysLeratRosso January 29, 2026 10:39

Uriel-Sautron force-pushed the hai/editoast-track-reference-filter branch from 089b066 to 07996a6 Compare January 29, 2026 12:08

SarahBellaha approved these changes Jan 29, 2026

View reviewed changes

SharglutDev approved these changes Jan 29, 2026

View reviewed changes

hamz2a and others added 10 commits January 29, 2026 15:38

editoast: add local_track_name to operational_points layer

4fb3f59

Signed-off-by: hamz2a <atrari.hamza@gmail.com>

test: fix local track name in medium infra

ce6074a

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for path step popup

343ebe1

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for simulation sheet

9f06c62

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for stdcm

cedfe28

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for input and output table

ddc3dc1

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for track occupancy diagram

86eab63

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: use local track name for new itinerary modal

02863a9

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

front: add local track name in oprational point layer

3da23b3

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>

Uriel-Sautron force-pushed the hai/editoast-track-reference-filter branch from 07996a6 to 3da23b3 Compare January 29, 2026 14:40

hamz2a added this pull request to the merge queue Jan 29, 2026

Merged via the queue into dev with commit 6f8d3d2 Jan 29, 2026
30 checks passed

hamz2a deleted the hai/editoast-track-reference-filter branch January 29, 2026 15:32

github-project-automation Bot moved this from Awaiting merge to Awaiting Validation in Board PI 18 Jan 29, 2026

hamz2a assigned Uriel-Sautron Jan 29, 2026

SharglutDev mentioned this pull request Jan 29, 2026

add cell editing to new Times stops table #14853

Merged

9 tasks

Maymanaf moved this from Awaiting Validation to Done in Board PI 18 Jan 30, 2026

Conversation

hamz2a commented Jan 20, 2026

Changes:

Uh oh!

github-actions Bot commented Jan 20, 2026

⚠️ API changes

Changes in Schemas

Uh oh!

flomonster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Khoyo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hamz2a commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Castavo left a comment

Choose a reason for hiding this comment

Uh oh!

SharglutDev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SarahBellaha left a comment

Choose a reason for hiding this comment

Uh oh!

SharglutDev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Khoyo left a comment •

edited

Loading

hamz2a commented Jan 20, 2026 •

edited

Loading