-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Type: BugIssues related to software defects or unexpected behavior, which require resolution.Issues related to software defects or unexpected behavior, which require resolution.reconciliationRelated to the reconciliation operations and other featuresRelated to the reconciliation operations and other featuresreconciliation API designwhen changing the reconciliation API is required to improve a workflowwhen changing the reconciliation API is required to improve a workflow
Milestone
Description
Since #3731, the OpenCorporates reconciliation endpoint (https://opencorporates.com/reconcile) does not work correctly in OpenRefine.
To Reproduce
Steps to reproduce the behavior:
- First, reconcile some list of companies to OpenCorporates
- Then, click one of the reconciliation candidates
Current Results
You land on a 404 page because the slash characters in the URL are incorrectly escaped.
Expected Behavior
Working URLs.
This could be achieved by:
- keeping the previous behaviour for services which do not declare any protocol version in their manifest (i.e. they are following 0.1)
- adjusting the specs (and OpenRefine's code) to specify in the templates whether escaping is expected or not (Placeholder for ids is not consistent between services reconciliation-api/specs#39)
Versions
- OpenRefine: 3.6-SNAPSHOT
Metadata
Metadata
Assignees
Labels
Type: BugIssues related to software defects or unexpected behavior, which require resolution.Issues related to software defects or unexpected behavior, which require resolution.reconciliationRelated to the reconciliation operations and other featuresRelated to the reconciliation operations and other featuresreconciliation API designwhen changing the reconciliation API is required to improve a workflowwhen changing the reconciliation API is required to improve a workflow