Skip to content

Use 'logger' instead of 'error_logger'#38

Merged
martinsumner merged 1 commit intoopenriak-3.4from
nhse-o34-orkv.i111-rmverrorlogger-clean
Mar 4, 2026
Merged

Use 'logger' instead of 'error_logger'#38
martinsumner merged 1 commit intoopenriak-3.4from
nhse-o34-orkv.i111-rmverrorlogger-clean

Conversation

@martinsumner
Copy link
Contributor

wday-contrib 2325

Passes all eqc tests

@martinsumner
Copy link
Contributor Author

OpenRiak/riak_kv#111

Copy link
Member

@WarpEngineer WarpEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through riak_core_util.erl since I'm guessing that was just formatting.

@martinsumner
Copy link
Contributor Author

@WarpEngineer

With regards to riak_core_util, it is a merge issue. There was a commit, adding the Workday attribution to the Apache license, and changing the pmap_test unit test (formatting only) ... but there's also some functions that had been added prior to this in the workday branch related to calculating timestamps (for your larger timeout monitoring change), which aren't in the openriak branch. This seems to confuse the diff process, and it creates a diff for the whole module.

Not sure how to avoid this., but there isn't any changes that I'm aware of other than those highlighted here. It might have been a mistake to take the wday commits out of order.

@WarpEngineer
Copy link
Member

@martinsumner I skimmed the file and compared to my local and it looks like the timeout functions are the major difference. I see no issues otherwise. I think it's good to go.

@martinsumner martinsumner merged commit 4ec6b05 into openriak-3.4 Mar 4, 2026
4 checks passed
@martinsumner martinsumner deleted the nhse-o34-orkv.i111-rmverrorlogger-clean branch March 4, 2026 10:42
@martinsumner martinsumner mentioned this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants