fix(cli): eliminate extra Ctrl+C needed to exit local spawn session#3430
Open
aulorbe wants to merge 1 commit into
Open
fix(cli): eliminate extra Ctrl+C needed to exit local spawn session#3430aulorbe wants to merge 1 commit into
aulorbe wants to merge 1 commit into
Conversation
After the agent exits via Ctrl+C (exit 130), two things added delay that forced the user to press Ctrl+C a third time: 1. spawnInteractive ran `stty sane` (a synchronous child spawn) after the agent exited, blocking during the exact moment the user expects the process to be dying. 2. runOrchestration continued through post-session cleanup (reconnect logic, history pull, tunnel teardown) before calling process.exit. Fix: on exit code 130, skip terminal cleanup in spawnInteractive and fast-path to process.exit(130) in runOrchestration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exiting a local spawn session with Ctrl+C requires pressing it three times instead of two. After the agent process exits on the second Ctrl+C, the parent process hangs briefly — long enough that the user presses Ctrl+C again.
Root cause
Two things add delay between the agent exiting and the process actually terminating:
spawnInteractiverunsstty sane— a synchronousnodeSpawnSynccall that blocks right after the agent exits, during the exact moment the user expects the process to be dying.runOrchestrationcontinues post-session cleanup — reconnect logic, tunnel teardown, and history pull all run beforeprocess.exit(), even on SIGINT where the user just wants out.Fix
ssh.ts: On exit code 130 orSIGINTsignal, skip terminal reset (stty sane, ANSI escape writes) and return immediately.orchestrate.ts: On exit code 130, callprocess.exit(130)immediately after the interactive session returns, skipping all post-session cleanup.Test plan
bunx @biomejs/biome check src/shared/ssh.ts src/shared/orchestrate.ts— zero errorsspawn cursor local, press Ctrl+C twice — should exit cleanly without needing a third press