fix(tests): reset telemetry singleton to prevent cross-test fetch leakage#3437
Open
la14-1 wants to merge 1 commit into
Open
fix(tests): reset telemetry singleton to prevent cross-test fetch leakage#3437la14-1 wants to merge 1 commit into
la14-1 wants to merge 1 commit into
Conversation
…est fetch leakage The telemetry test calls initTelemetry() which sets _enabled=true in the singleton module. Without resetting, logWarn/logError in subsequent test files (e.g. hetzner-cov) trigger unexpected fetch() calls via captureWarning/captureError, shifting mock callCount counters and causing test failures. Add resetTelemetry() export and call it in telemetry test afterEach. Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Fixes 1 consistently failing test in the full suite (
hetzner/createServer > cleans up orphaned primary IPs on resource_limit_exceeded and retries). The telemetry singleton's_enabledflag leaked across test files, causinglogWarn/logErrorto fire unexpectedfetch()calls that shifted mock counters.Changes
packages/cli/src/shared/telemetry.ts— AddedresetTelemetry()export that resets singleton statepackages/cli/src/__tests__/telemetry.test.ts— CallresetTelemetry()inafterEachto clean uppackages/cli/package.json— Version bump 1.1.0 → 1.1.1Test plan
bun test— 2205 pass, 0 fail (was 2204 pass, 1 fail)bun test telemetry.test.ts hetzner-cov.test.ts— confirms the specific interaction is fixed-- refactor/test-engineer