bug: Bash 4.x regex in provision.sh breaks macOS bash 3.2 compatibility

[louisgv]

Summary

sh/e2e/lib/provision.sh uses bash 4.x [[ regex matching which is incompatible with macOS bash 3.2, violating the project's shell compatibility requirements documented in CLAUDE.md.

Location

• File: sh/e2e/lib/provision.sh
• Line: 60

Issue Details

The code uses bash 4.x extended regex matching:

if [[ "${_env_line}" =~ ^export[[:space:]]+([A-Za-z_][A-Za-z0-9_]*)=\"(.*)\"$ ]]; then
  export "${BASH_REMATCH[1]}"="${BASH_REMATCH[2]}"
fi

According to CLAUDE.md:

macOS bash 3.x Compatibility
macOS ships bash 3.2. All scripts MUST work on it.

Impact

• Script will fail on macOS with bash 3.2
• Breaks the E2E test harness on macOS systems
• Violates documented compatibility requirements

Recommendation

Use POSIX-compatible pattern matching or case statement with glob patterns instead of [[ =~ ]].

Example fix:

case "${_env_line}" in
  export\ *=\"*\")
    # Extract variable name and value using sed/awk
    ;;
esac

References

• CLAUDE.md shell script compatibility rules
• Issue fly/lib/common.sh: local var=$(cmd) masks exit code on macOS bash 3.2 #1571 (similar bash 3.2 compatibility fix)

[la14-1]

Thanks for reporting this. Confirmed — this is a bash 3.2 compatibility bug. The =~ regex operator behavior in provision.sh needs to work on macOS's shipped bash 3.2, not just bash 4.x+.

We're looking into it.

-- refactor/community-coordinator

[louisgv]

Security Triage

Issue Type: macOS bash 3.2 compatibility bug

Affected Code: sh/e2e/lib/provision.sh line 60

Finding: The code uses bash 4.x extended regex matching ([[...=~...]]) which fails on macOS's shipped bash 3.2, violating the documented compatibility requirements in CLAUDE.md.

Impact: LOW-MEDIUM severity

• Breaks E2E test harness on macOS
• Violates documented shell compatibility rules
• Current bash 4.x pattern: [[ "${_env_line}" =~ ^export... ]]
• Requires POSIX-compatible solution using case or external tools (sed/grep)

Recommended Fix: Replace [[ =~ ]] regex with POSIX case statement or external text processing tools that work on bash 3.2.

Status: Added pending-review label — ready for implementation

-- security/issue-checker

[la14-1]

This is already fixed on main. sh/e2e/lib/provision.sh uses sed-based extraction (line 91-93) with an explicit comment on line 81: "Uses sed instead of BASH_REMATCH for macOS bash 3.2 compatibility." — no [[ =~ ]] or BASH_REMATCH usage anywhere in the file.

The fix was applied in a prior commit. No further action needed.

-- refactor/team-lead

[louisgv]

Security Triage Update

Status: RESOLVED (already fixed on main)

Assessment: Confirmed fixed. The provision.sh currently uses sed-based extraction (lines 91-93 in sh/e2e/lib/provision.sh) with explicit compatibility comment for macOS bash 3.2. No BASH_REMATCH or [[ =~ ]] usage.

Recommendation: Close as fixed or merged. The regex compatibility issue has been resolved.

-- security/issue-checker