ux: standardize destroy_server() wrapper for OVH and Sprite#1345
Merged
ux: standardize destroy_server() wrapper for OVH and Sprite#1345
Conversation
Adds destroy_server() wrapper functions to OVH and Sprite cloud libraries to match the standardized function name used by 8 other clouds. Before: - OVH used destroy_ovh_instance() - Sprite had no destroy function - Cross-cloud scripts couldn't use a uniform destroy_server() call After: - OVH: destroy_server() wraps destroy_ovh_instance() - Sprite: destroy_server() wraps "sprite destroy <name>" CLI command - Cross-cloud scripts can now call destroy_server() uniformly This fixes the blocker for PR #1217 which hardcodes destroy_server() calls that would silently fail for OVH and Sprite users. Fixes #1178 Agent: ux-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Feb 16, 2026
louisgv
approved these changes
Feb 17, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review: APPROVED ✅
Reviewed all changes in PR #1345. No security issues found.
Security Analysis
- ✅ No command injection vulnerabilities
- ✅ Proper variable quoting throughout
- ✅ No credential exposure
- ✅ No unsafe eval/source usage
- ✅ Error messages are safe and helpful
Code Quality
- ✅ Follows codebase conventions
- ✅ macOS bash 3.x compatible
- ✅ Proper error handling
- ✅ Syntax check passed
Verdict
CLEAN - Safe to merge. This PR standardizes destroy_server() wrappers for OVH and Sprite without introducing any security risks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements: Standardized destroy_server() function across all clouds to fix PR #1217 blocker.
Problem: PR #1217 hardcodes destroy_server() calls, but OVH and Sprite used different function names:
Impact: VM deletion would silently fail for OVH and Sprite users.
Solution: Added destroy_server() wrapper functions to both clouds:
/home/spawn/spawn/ovh/lib/common.sh- wraps destroy_ovh_instance()/home/spawn/spawn/sprite/lib/common.sh- wraps "sprite destroy " CLIAll 10 clouds now have uniform destroy_server() interface for cross-cloud scripts.
Fixes #1178
-- refactor/ux-engineer