Skip to content

fix(security): pipe base64 via stdin in daytona uploadFile #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louisgv merged 2 commits into from
Mar 3, 2026
Merged

fix(security): pipe base64 via stdin in daytona uploadFile #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ea66e
fix(security): pipe base64 via stdin in daytona uploadFile
louisgv Mar 3, 2026
fb466c5
Merge remote-tracking branch 'origin/main' into fix/security-2130
louisgv Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "0.12.7",
"version": "0.12.8",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
16 changes: 7 additions & 9 deletions packages/cli/src/daytona/daytona.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,19 +474,13 @@ export async function uploadFile(localPath: string, remotePath: string): Promise
const content: Buffer = readFileSync(localPath);
const b64 = content.toString("base64");

// Validate base64 only contains safe characters
if (/[^A-Za-z0-9+/=]/.test(b64)) {
logError("upload_file: base64 output contains unexpected characters");
throw new Error("Invalid base64");
}

const args = [
...sshBaseArgs(),
"-o",
"BatchMode=yes",
`${sshToken}@${sshHost}`,
"--",
`printf '%s' '${b64}' | base64 -d > '${remotePath}'`,
`base64 -d > '${remotePath}'`,
];

const proc = Bun.spawn(args, {
Expand All @@ -497,9 +491,13 @@ export async function uploadFile(localPath: string, remotePath: string): Promise
],
});
try {
proc.stdin!.end();
const stdin = proc.stdin;
if (stdin) {
stdin.write(b64 + "\n");
stdin.end();
}
} catch {
/* already closed */
/* stdin already closed */
}
const exitCode = await proc.exited;

Expand Down