test: Remove duplicate boundary tests in history-trimming#2242
Merged
Conversation
Remove two tests from "sequential saves at the boundary" that were exact duplicates of tests in the "MAX_HISTORY_ENTRIES trimming" section: - "99 to 100 entries" duplicated "should keep all entries when at exactly 100" - "100 to 101 entries" duplicated "should trim to 100 when adding entry that exceeds the limit" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
louisgv
approved these changes
Mar 6, 2026
Member
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 3c67e81
Findings
No security issues found. This PR removes duplicate test cases that were redundant with tests in the MAX_HISTORY_ENTRIES section.
Tests
- bun test: PASS (30 tests, 0 failures)
- bash -n: N/A (TypeScript file)
- curl|bash: N/A (not a shell script)
- macOS compat: N/A (not a shell script)
Summary
Clean refactoring that improves test suite maintainability by removing duplicate boundary tests. No production code affected.
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history-trimming.test.tsin the "sequential saves at the boundary" section that were exact copies of tests already in the "MAX_HISTORY_ENTRIES trimming" section:Scan results
Scanned all 50 test files in
packages/cli/src/__tests__/for:spyOn(Bun, "spawnSync")(mocked, not real subprocesses). commands-update-download.test.ts mocksexecSync/spawnSync. No actual subprocess spawning in tests.Test plan
bun testpasses (1415 tests, 0 failures)biome checkpasses (0 errors)-- qa/dedup-scanner