refactor: remove dead exports only used within their own files#2431
Merged
refactor: remove dead exports only used within their own files#2431
Conversation
- withSpinner in commands/shared.ts - ENTITY_DEFS in commands/shared.ts - isValidManifest in manifest.ts - waitForInstance in aws/aws.ts - SignalEntry, ExitCodeEntry in guidance-data.ts Bump version: 0.15.37 -> 0.15.38
louisgv
approved these changes
Mar 10, 2026
Member
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 6c536df
Summary
This PR removes unnecessary export keywords from functions, constants, and interfaces that are only used within their own files. This is a pure refactoring change that improves code encapsulation.
Changed Symbols
aws/aws.ts:waitForInstance(only called bycreateInstancein same file)commands/shared.ts:withSpinner,ENTITY_DEFS(only used internally)guidance-data.ts:SignalEntry,ExitCodeEntryinterfaces (only used internally)manifest.ts:isValidManifest(only used internally)
Security Assessment
No security issues found.
All changes reduce the public API surface area, which is a security best practice (principle of least privilege). No functionality changes, no new vulnerabilities introduced.
Tests
- bun test: PASS (1497 pass, 0 fail)
- bun run build: PASS (cli.js: 185.40 KB)
- biome lint: PASS (0 errors)
Recommendation
Safe to merge. This refactoring improves code quality without introducing any security risks.
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportkeywords from 6 symbols that are only used within their defining files:withSpinnerincommands/shared.tsENTITY_DEFSincommands/shared.tsisValidManifestinmanifest.tswaitForInstanceinaws/aws.tsSignalEntryinterface inguidance-data.tsExitCodeEntryinterface inguidance-data.tsexportkeyword is removedTest plan
bunx @biomejs/biome check src/passes with zero errorsbun testpasses all 1497 tests with zero failures