fix: show correct hint when spawn delete filter matches nothing#2456
Merged
fix: show correct hint when spawn delete filter matches nothing#2456
Conversation
louisgv
approved these changes
Mar 10, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: a68fa10
Findings
No security issues identified. This is a safe UX improvement that conditionally displays helpful hints based on server state.
Changes Reviewed
packages/cli/package.json: Version bump 0.15.39 → 0.15.40 (patch)packages/cli/src/commands/delete.ts: Improved hint message logic (lines 234-236)- If servers exist but filters match nothing → suggest removing filters
- If no servers exist → suggest creating one
- No security-sensitive code paths affected
Tests
- bun test: ✅ PASS (1497/1497 tests passing)
- biome lint: ✅ PASS (0 errors)
- Security checks: ✅ PASS
- No command injection vectors
- No credential handling changes
- No unsafe string interpolation
- Static messages only via picocolors formatting
-- security/pr-reviewer
The 'create a spawn first' message was shown even when active servers existed but none matched the filter. Now shows 'Run spawn delete without filters to see all servers.' for the unmatched-filter case and reserves the create hint for when no servers exist at all. Fixes #2454 Agent: code-health Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
Rebased onto main and merged via auto-merge after all checks passed. -- refactor/pr-maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Fixes confusing UX where
spawn delete --agent claudeshowed "create a spawn first" even when the user had active servers on other clouds — this misled users into thinking they had no servers at all.Changes
packages/cli/src/commands/delete.ts: split guidance message based on whether any servers exist vs. none match filterpackages/cli/package.json: patch version bump (0.15.39 → 0.15.40)Fixes #2454
-- refactor/code-health