feat: unified arrow-key selection + setup checkboxes#2459
Merged
la14-1 merged 3 commits intoOpenRouterTeam:mainfrom Mar 10, 2026
Merged
feat: unified arrow-key selection + setup checkboxes#2459la14-1 merged 3 commits intoOpenRouterTeam:mainfrom
la14-1 merged 3 commits intoOpenRouterTeam:mainfrom
Conversation
Replace p.autocomplete (type-ahead) with p.select (arrow-key navigation) for agent and cloud selection. Add p.multiselect checkboxes for optional post-provision setup steps (GitHub CLI, Chrome browser), all ON by default. Three fast prompts: agent → cloud → setup options. Defaults: OpenClaw, first cloud with credentials, all steps enabled. Key changes: - interactive.ts: p.autocomplete → p.select with initialValue defaults - interactive.ts: promptSetupOptions() with p.multiselect, exported for reuse - run.ts: wire setup options into cmdRun direct path - agents.ts: OptionalStep type, getAgentOptionalSteps() static metadata - orchestrate.ts: read SPAWN_ENABLED_STEPS env var, gate GitHub auth + configure - agent-setup.ts: gate Chrome install with enabledSteps in setupOpenclawConfig - Version bump 0.15.40 → 0.16.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Tarballs are built with absolute /root/ paths, but GCP and AWS Lightsail SSH as a regular user whose $HOME is /home/<user>/. After extraction, binaries like `claude` end up at /root/.claude/local/bin/ but the launchCmd looks in $HOME/.claude/local/bin/ — causing "command not found". Add a post-extraction step that copies /root/ dotfiles to $HOME/ when the SSH user isn't root. This fixes `spawn claude gcp` failing with exit code 127 after tarball install. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
louisgv
approved these changes
Mar 10, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: d1a5db8
Summary
This PR adds multiselect setup options for post-provision steps (GitHub CLI, Chrome browser). Clean implementation with no security issues.
Findings
- No critical or high severity issues
- MEDIUM: Subprocess spawning for GitHub token detection - properly sanitized with hardcoded command array
- MEDIUM: Env var parsing for SPAWN_ENABLED_STEPS - safe (only used for boolean checks, no injection risk)
- All user input properly validated and contained
Positive Practices
- Changed from autocomplete to arrow-key selection (simpler, safer)
- Safe defaults on cancel (all steps enabled)
- Static metadata for optional steps (not user-controlled)
- Proper test coverage with cleanup
Tests
- bash -n: N/A (no shell scripts changed)
- bun test: PASS (1497 tests, 0 failures)
- biome lint: PASS (0 errors)
- curl|bash safety: N/A (no shell scripts)
- macOS compat: N/A (no shell scripts)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p.autocomplete(type-ahead) withp.select(arrow-key navigation) for agent and cloud selection promptsp.multiselectcheckboxes for optional post-provision setup steps (GitHub CLI, Chrome browser) — all ON by default, user can uncheck to skipSPAWN_ENABLED_STEPSenv var so orchestrate.ts gates GitHub auth and Chrome installChanges
commands/interactive.tsp.autocomplete→p.selectwithinitialValuedefaults; newpromptSetupOptions()+hasLocalGithubToken()commands/run.tspromptSetupOptionsintocmdRundirect pathshared/agents.tsOptionalSteptype,getAgentOptionalSteps()static metadatashared/orchestrate.tsSPAWN_ENABLED_STEPSenv var, gate GitHub auth + passenabledStepstoconfigureshared/agent-setup.tsinstallChromeBrowserwithenabledStepsinsetupOpenclawConfig__tests__/orchestrate.test.tsconfigurecall expectations for newenabledStepsparampackage.json0.15.40→0.16.0Test plan
bunx @biomejs/biome check src/— 0 errors (114 files)bun test— 1497 tests pass, 0 failuresspawn→ arrow-key agent select (default: OpenClaw) → arrow-key cloud select → checkbox setup steps (GitHub + Chrome checked)spawn claude hetzner→ setup checkboxes shown before spawn name prompt🤖 Generated with Claude Code