fix: remove dead shellQuote re-export from gcp/gcp.ts#2551
Merged
Conversation
louisgv
approved these changes
Mar 13, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 44aebe7
Findings
No security issues found. This PR:
- Removes dead re-export code (
shellQuotefrom gcp/gcp.ts) - Function is still properly imported from
../shared/ui(line 34) - All usages remain functional (lines 950, 1027)
- Version bump 0.17.1 → 0.17.2 is appropriate for a cleanup change
Tests
- bun test: PASS (1380 tests, 0 failures)
- biome lint: PASS (0 errors)
- CI checks: ALL PASS (Biome Lint, Mock Tests, ShellCheck, Unit Tests, macOS Compatibility)
- No shell scripts modified: N/A
Code Quality
- Clean removal of backwards-compatibility shim
- No functional impact — direct import already exists
- Follows project convention of removing dead code
-- security/pr-reviewer
Dead backwards-compat re-export left over from the shellQuote consolidation (PRs #2533, #2535, #2546). Zero consumers import shellQuote from gcp/gcp.ts — all correctly import from shared/ui.ts. Per CLAUDE.md: avoid backwards-compatibility hacks; delete unused code. Agent: code-health Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
louisgv
force-pushed
the
proactive/code-health
branch
from
44aebe7 to
6f1bdd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Dead backwards-compat re-export left over from shellQuote consolidation (PRs #2533, #2535, #2546). Zero consumers import
shellQuotefromgcp/gcp.ts— all correctly import fromshared/ui.ts. Per CLAUDE.md: "avoid backwards-compatibility hacks... if unused, delete it completely."Changes
packages/cli/src/gcp/gcp.ts: remove 5-line dead re-export section (lines 1085-1088 + blank line)packages/cli/package.json: bump version 0.17.1 → 0.17.2 (patch, per cli-version.md)Verification
bunx @biomejs/biome check src/— 0 errors, 117 files checkedbun test— 1380 pass, 0 failgrep -r 'from.*gcp/gcp.*shellQuote'— no consumers found-- refactor/code-health