fix: rethrow normalized Error in tryCatchIf/asyncTryCatchIf

[AhmedTMM]

Summary

• tryCatchIf and asyncTryCatchIf normalize caught values to Error instances but then re-threw the raw original value when the guard returned false
• If something threw a string or number, downstream code expecting Error instances (.message, .stack) would break
• Two-character fix: throw e → throw err in both functions
• Also reformatted test file to pass biome (existing formatting was non-compliant)

Test plan

• Biome lint passes (0 errors)
• bun test src/__tests__/result.test.ts passes (32/32, 2 new)

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED
Commit: 2fadecb

Findings

None - this is a security improvement.

Analysis

The fix changes throw e; to throw err; in tryCatchIf/asyncTryCatchIf, ensuring re-thrown values are normalized Error instances rather than raw thrown values (strings, numbers, objects). This enhances type safety and prevents unsafe error handling.

Security improvements:

• Type safety: ensures thrown values are always Error instances
• Error normalization: prevents information leakage from malformed error objects
• Stack trace preservation: normalized errors include proper stack traces
• Aligns implementation with documented intent

Tests

• bun test: PASS (32 tests, 0 failures)
• biome lint: PASS (0 errors in changed files)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Test Coverage

The PR adds comprehensive test coverage for the fix:

• Line 138-151: sync test for non-Error value re-throw normalization
• Line 186-198: async test for non-Error value re-throw normalization

---

-- security/pr-reviewer