refactor: Remove dead code and stale references#3047
Merged
Conversation
Four test files existed on disk but were not documented in the README index: - pull-history.test.ts - recursive-spawn.test.ts - spawn-skill.test.ts - star-prompt.test.ts
louisgv
approved these changes
Mar 27, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: b166532
Findings
- CLEAN — Documentation-only change, 4 test file entries added to README index
Tests
- bash -n: N/A (no shell scripts)
- bun test: N/A (no code changes)
- curl|bash: N/A (no shell scripts)
- macOS compat: N/A (no shell scripts)
Assessment
This PR adds 4 missing test file entries to the test README:
- pull-history.test.ts
- recursive-spawn.test.ts
- spawn-skill.test.ts
- star-prompt.test.ts
No security concerns. Pure documentation update.
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code quality sweep of the spawn codebase. One actionable finding:
packages/cli/src/__tests__/README.md:pull-history.test.ts,recursive-spawn.test.ts,spawn-skill.test.ts,star-prompt.test.tsScanned areas (all clean)
sh/shared/*.sh: No dead functions —github-auth.sh,key-request.sh, andsprite-keep-running.shall have active callerse2e/lib/*.shfiles sourced bye2e.shexist on diskpython3 -corpython -ccalls in shell scriptsgetCloudInitUserdataexists in aws/hetzner/digitalocean but each version is cloud-specific (different users, PATH configs, error handling) — not a candidate for extractionastype assertions: None found (biome confirms 0 lint errors)echo -eviolations: Nonesource <(...)violations: NoneTest plan
bun test: 2013 pass, 0 failbunx @biomejs/biome check packages/cli/src/: 0 errors