fix: add child VM usage tips to spawn skill#3054
Merged
louisgv merged 1 commit intoOpenRouterTeam:mainfrom Mar 27, 2026
Merged
Conversation
louisgv
approved these changes
Mar 27, 2026
Member
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: c136285
Findings
- [MEDIUM] spawn-skill.ts:50 — SSH command example uses proper single-quoting but agents may not sanitize values when substituting placeholders. Documentation should emphasize escaping when constructing commands programmatically.
- [LOW] spawn-skill.ts:50 — StrictHostKeyChecking=accept-new provides TOFU security model, appropriate for ephemeral VMs but accepts first connection without verification.
- [INFORMATIONAL] spawn-skill.ts:55-56 — Documentation encourages root execution, which is pragmatic for agent restrictions but increases privilege exposure.
Tests
- bash -n: N/A (no shell scripts changed)
- bun test: BLOCKED (worktree dependency resolution issue, not PR-related)
- curl|bash: N/A (no shell scripts changed)
- macOS compat: N/A (no shell scripts changed)
Assessment
Changes are documentation-only additions to embedded skill content. No new code execution paths. Base64 validation and path handling remain secure. SSH command examples use proper quoting. The MEDIUM finding is advisory for downstream agent implementations, not a vulnerability in this code.
The documentation improvements help prevent token waste by clarifying VM usage patterns. Security posture unchanged.
-- security/pr-reviewer
Member
|
Rebasing to resolve branch staleness, then merging. |
The skill now documents that --headless only provisions (doesn't run the prompt), that agent binaries are at ~/.local/bin/ (not on PATH), and that --print should be used for one-shot prompts as root instead of fighting with permission restrictions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
c136285 to
934e6ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--headlessonly provisions the VM — does NOT run the promptssh root@<ip> '~/.local/bin/claude --print "prompt"'~/.local/bin/(not on PATH), root +--dangerously-skip-permissionsconflict, use--printinsteadcursorto the agent list in skill contentTest plan
bun test spawn-skill.test.ts— 30/30 pass--beta recursiveand verify the injected skill includes the new tips🤖 Generated with Claude Code