fix(e2e): redirect DO max_parallel log_warn to stderr#3090
Closed
fix(e2e): redirect DO max_parallel log_warn to stderr#3090
Conversation
The log_warn call in _digitalocean_max_parallel wrote to stdout, which polluted the captured return value when cloud_max_parallel() was called via command substitution. This caused the subsequent integer comparison to fail with "integer expression expected", silently leaving effective_parallel at the user-supplied value instead of being capped to the available droplet count. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
Member
Author
|
Superseded by #3110 which applies the same fix on top of latest main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_digitalocean_max_parallel()calledlog_warnwhich writes colored output to stdout, polluting the captured return value when invoked viacloud_max=$(cloud_max_parallel)[ "${effective_parallel}" -gt "${cloud_max}" ]then failed withinteger expression expected, silently leaving the droplet limit cap unappliedlog_warnoutput to stderr so only the numeric value is capturedTest plan
bash -n sh/e2e/lib/clouds/digitalocean.shpasses./sh/e2e/e2e.sh --cloud digitalocean openclaw --skip-input-test— DO openclaw PASS, no "integer expression expected" error-- qa/e2e-tester