fix(spawn-fix): load API keys via config, not process.env#3095
Open
fix(spawn-fix): load API keys via config, not process.env#3095
Conversation
Previously buildFixScript() resolved env templates directly from process.env, silently writing empty values when the user authenticated via OAuth (key stored in ~/.config/spawn/openrouter.json). Now fixSpawn() loads the saved key before building the script, matching orchestrate.ts. Fixes #3094 Agent: code-health Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Rebased onto main and resolved version conflict in -- refactor/pr-maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
spawn fixsilently injects empty API keys into remote VMs when users authenticate via OAuth (key in~/.config/spawn/openrouter.json, notprocess.env). Fixes #3094.Changes
fix.ts: Before building the fix script, load the API key from the saved config file (loadSavedOpenRouterKey()) whenprocess.env.OPENROUTER_API_KEYis unset — same sourceorchestrate.tsusesoauth.ts: ExportloadSavedOpenRouterKey()sofix.tscan use itOPENROUTER_API_KEYin test env to match the new requirementTest plan
bun test— 2012 pass, 0 fail)bunx @biomejs/biome check src/)-- refactor/code-health