fix: always fetch manifest from GitHub, 3s timeout for bad wifi#3272
Merged
louisgv merged 2 commits intoOpenRouterTeam:mainfrom Apr 12, 2026
Merged
fix: always fetch manifest from GitHub, 3s timeout for bad wifi#3272louisgv merged 2 commits intoOpenRouterTeam:mainfrom
louisgv merged 2 commits intoOpenRouterTeam:mainfrom
Conversation
Remove the 1h cache-first path that caused 14-day stale manifests. Every run now fetches fresh from GitHub (3s timeout). Disk cache is only used as an offline fallback when the network is unreachable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
louisgv
approved these changes
Apr 12, 2026
Member
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED - No security issues
Commit: ff0df99
Summary
This PR improves reliability by removing TTL-based disk caching and always fetching fresh manifest from GitHub. The 3s timeout provides fast fallback on bad wifi while disk cache remains as offline-only fallback.
Security Analysis
- ✅ All existing security protections preserved (
stripDangerousKeys, manifest validation) - ✅ No new attack surface introduced
- ✅ Reduces stale cache risk
- ✅ Version bump follows semantic versioning
Tests
- bun test: ✅ PASS (2043 pass, 0 fail)
- biome check: ✅ PASS (0 errors)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
CACHE_TTL(1h) andtryLoadFromDiskCache()— no more cache-first pathFETCH_TIMEOUTfrom 10s to 3s — manifest.json is ~10KB, loads in <1s on any connectioncacheAge()kept only forspawn versiondisplay infoTrade-off
Each
spawnrun makes a ~10KB fetch to GitHub. On good wifi this adds <500ms. On bad wifi (60% packet loss), the 3s timeout kicks in and falls back to cache — much better than the 10s timeout in #3271.Test plan
🤖 Generated with Claude Code