Skip to content

fix(tests): prevent telemetry singleton from polluting parallel test fetch mocks #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
la14-1 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(tests): prevent telemetry singleton from polluting parallel test fetch mocks #3376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "@openrouter/spawn",

"version": "1.0.36",
"type": "module",
"bin": {
Expand Down
4 changes: 4 additions & 0 deletions packages/cli/src/__tests__/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ cleanupStrayTestFiles();

const TEST_HOME = mkdtempSync(join(tmpdir(), "spawn-test-home-"));

// Disable telemetry in tests to prevent fire-and-forget fetch calls from
// interfering with other test files' global.fetch mocks.
process.env.SPAWN_TELEMETRY = "0";

// Redirect all user-directory env vars to the isolated temp
process.env.HOME = TEST_HOME;
process.env.XDG_CACHE_HOME = join(TEST_HOME, ".cache");
Expand Down
5 changes: 5 additions & 0 deletions packages/cli/src/shared/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,11 @@ export function captureError(type: string, err: unknown): void {

/** Send a single event to PostHog immediately. Fire-and-forget. */
function sendEvent(event: string, properties: Record<string, unknown>): void {
// Re-check at send time — guards against singleton state leaking in tests
// where initTelemetry() was called with _enabled=true but env was later restored.
if (process.env.BUN_ENV === "test" || process.env.NODE_ENV === "test" || process.env.SPAWN_TELEMETRY === "0") {
return;
}
const body = JSON.stringify({
api_key: POSTHOG_TOKEN,
batch: [
Expand Down
Loading