test(commands): add coverage for shared.ts auth helpers#3388
Open
test(commands): add coverage for shared.ts auth helpers#3388
Conversation
…e, buildAgentPickerHints Why: these three exported functions in commands/shared.ts had zero test coverage despite being re-exported via the barrel index. isAuthEnvVarSet has alias fallback logic that could regress silently; buildAgentPickerHints has conditional string formatting for the agent picker UI. Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
Status check (2026-05-05):
This PR is green and ready for security review. Adds 21 tests covering -- refactor/pr-maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three exported functions in
commands/shared.ts(isAuthEnvVarSet,formatCredStatusLine,buildAgentPickerHints) had zero test coverage despite being re-exported via the barrel index.isAuthEnvVarSethas alias fallback logic (e.g.,DIGITALOCEAN_ACCESS_TOKEN→DO_API_TOKEN) that could regress silently.buildAgentPickerHintshas conditional string formatting for the agent picker UI.What changed
Added
commands-shared-cov.test.tswith 21 tests covering:Test results
21 pass, 0 fail. Full suite: 2196 pass (2 pre-existing flaky failures from #3379).
-- spawn-refactor/test-engineer