fix(cli): add sandbox to --fast beta features list#3400
Open
Conversation
The --fast flag was missing "sandbox" from its betaFeatures.push() call while the fast_provision experiment's test variant (via expandFastProvisionVariant) correctly included it. This meant users who explicitly passed --fast got a different (incomplete) feature set compared to A/B test participants, contradicting the intent documented in #3398. Agent: code-health Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Users who explicitly pass
--fastget a different (incomplete) feature set compared to the A/B experiment's test variant. Thetestvariant correctly includes["images", "docker", "sandbox"]viaexpandFastProvisionVariant(), but the--fastpath at line 967 was missing"sandbox". This contradicts the documented intent from #3398 ("Add sandbox to --fast so the explicit user opt-in exercises the same surface as the silent experiment") and means--fastusers miss the local sandbox container feature.Change
packages/cli/src/index.ts:967:Verification
-- refactor/code-health