ci: add typecheck validation for tests and examples #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive TypeScript type checking to the Speakeasy PR workflow: - Typecheck all files in tests/ directory - Typecheck examples root directory - Typecheck examples/nextjs-example project - Build SDK before running typechecks to ensure examples can import correctly This ensures all TypeScript code passes type validation before changes are committed.
yogasanas
reviewed
Oct 28, 2025
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' |
Contributor
There was a problem hiding this comment.
Nit: Should we pin to 22?
yogasanas
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive TypeScript type checking to the Speakeasy PR workflow to ensure all code passes type validation before changes are committed.
Changes
tests/directoryexamples/root directoryexamples/nextjs-exampleprojectTest Plan