Skip to content

Do not put footer to the user manual#1828

Merged
evgenyz merged 1 commit into
OpenSCAP:maint-1.3from
jan-cerny:manual_no_footer
Nov 11, 2021
Merged

Do not put footer to the user manual#1828
evgenyz merged 1 commit into
OpenSCAP:maint-1.3from
jan-cerny:manual_no_footer

Conversation

@jan-cerny
Copy link
Copy Markdown
Member

@jan-cerny jan-cerny commented Nov 10, 2021

The footer contains the date of the last build.

Different date can cause this problem of rpmdeplint:
Undeclared file conflicts:
openscap-1.3.5-8.el8.i686 provides /usr/share/doc/openscap/manual/manual.html which is also provided by openscap-1.3.5-8.el8.x86_64
openscap-1.3.5-8.el8.x86_64 provides /usr/share/doc/openscap/manual/manual.html which is also provided by openscap-1.3.5-8.el8.i686

We can avoid it by simply removing the date.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2022364

The footer contains the date of the last build.

Different date can cause this problem of rpmdeplint:
Undeclared file conflicts:
openscap-1.3.5-8.el8.i686 provides /usr/share/doc/openscap/manual/manual.html which is also provided by openscap-1.3.5-8.el8.x86_64
openscap-1.3.5-8.el8.x86_64 provides /usr/share/doc/openscap/manual/manual.html which is also provided by openscap-1.3.5-8.el8.i686

We can avoid it by simply removing the date.
@jan-cerny jan-cerny added this to the 1.3.6 milestone Nov 10, 2021
@evgenyz
Copy link
Copy Markdown
Contributor

evgenyz commented Nov 10, 2021

But the proper way to fix it would be to extract the manual into the openscap-doc.noarch package. Am I correct?

@jan-cerny
Copy link
Copy Markdown
Member Author

I don't know. Probably yes. But this seems easier.

I was inspired by the recommendation to remove the timestamp for the Doxygen files: https://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks#Doxygen_footers

@evgenyz evgenyz merged commit 068afed into OpenSCAP:maint-1.3 Nov 11, 2021
@jan-cerny jan-cerny deleted the manual_no_footer branch November 11, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants