Organize XmlNode vs. XmlFile types#19
Merged
dLobatog merged 1 commit intoOpenSCAP:masterfrom Oct 14, 2019
akofink:files-refactoring
Merged
Organize XmlNode vs. XmlFile types#19dLobatog merged 1 commit intoOpenSCAP:masterfrom akofink:files-refactoring
dLobatog merged 1 commit intoOpenSCAP:masterfrom
akofink:files-refactoring
Conversation
xprazak2
reviewed
Oct 10, 2019
Collaborator
|
The new structure looks pretty neat. |
dLobatog
approved these changes
Oct 10, 2019
Contributor
dLobatog
left a comment
dLobatog
left a comment
There was a problem hiding this comment.
Works generally well when used with https://github.com/RedHatInsights/compliance-backend/pull/234/files/ec3c4a4a92d0bfd932c4dcd4b37e33c37cd34dc8 👍 , thanks @akofink
Collaborator
|
Needs a rebase. |
Signed-off-by: Andrew Kofink <akofink@redhat.com>
Collaborator
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope you will find this much more organized and easier to work with. It's organized in the following manner:
XmlFileclasses for dealing with the different Xccdf XML files :DatastreamFileTestResultFile# this used to be OpenscapParser::BaseTailoringFileXmlNodeclasses which match a capitalized Xccdf type in XML (i.e.<Profile />not<profile />):BenchmarkProfileRuleRuleIdentifierRuleReferenceTestResultRuleResultTailoringModules for parsing the various
XmlNodetypes fromXmlFiletypes:BenchmarksProfilesRulesRuleReferencesTestResultsRuleResultsTailoringsSigned-off-by: Andrew Kofink akofink@redhat.com