[WIP] - Parse arf reports#6
Closed
xprazak2 wants to merge 1 commit intoOpenSCAP:masterfrom
Closed
Conversation
akofink
reviewed
Aug 2, 2019
Collaborator
akofink
left a comment
akofink
left a comment
There was a problem hiding this comment.
Nice refactor - we could merge the refactor by itself without the Arf additions if that would make it easier for you to work on the PR. It'd certainly make reviewing it easier :)
Collaborator
Author
|
Thank you for review, I opened #7 with the refactoring. |
Collaborator
|
Should we close this as stale? |
Collaborator
Author
|
Yes, I think we can close. I will reopen when I have time to move forward with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might need additional changes, opening as wip for visibility.