This repository was archived by the owner on Sep 27, 2024. It is now read-only.
Do not show results panel when dry running#93
Merged
rsprudencio merged 1 commit intoOpenSCAP:v1-1from Dec 7, 2016
Merged
Conversation
When users starts a dry run scan they should only see the dialog with the command that would be performed. RHBZ#1385549
rsprudencio
reviewed
Dec 7, 2016
| // User will see the CommandLineArgsDialog and then the MainWindow | ||
| // ready for a new scan, or dry run | ||
| if (mUI.dryRunCheckBox->isChecked()) | ||
| clearResults(); |
Contributor
There was a problem hiding this comment.
The dry-run is actually ran and then results are cleared? Then it's not a dry-run, is it?
Member
There was a problem hiding this comment.
There are no results, this is done just to move the internal state of SCAP Workbench back to the pre-scan state.
Contributor
There was a problem hiding this comment.
Well, it looks good to me then. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users starts a dry run scan they should only see the dialog with
the command that would be performed.
RHBZ#1385549