Fixing nfde and fdtdjson parsing mismatch #298
Merged
lmdiazangulo merged 61 commits intodevfrom Mar 19, 2026
Merged
Conversation
lmdiazangulo
changed the title
lmdiazangulo
changed the title
…fdtd into fixing-nfde-fdtdjson-mismatch
…fdtd into fixing-nfde-fdtdjson-mismatch
…fdtd into fixing-nfde-fdtdjson-mismatch
Contributor
Author
|
@copilot try to fix this |
Contributor
|
@lmdiazangulo I've opened a new pull request, #313, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
Author
|
@copilot do another sub-PR trying to fix only the issues with the failing jobs at the current state. |
…fdtd into fixing-nfde-fdtdjson-mismatch
…ity and performance
Contributor
Author
|
@copilot try to fix these failing tests. |
Contributor
|
@lmdiazangulo I've opened a new pull request, #327, to work on those changes. Once the pull request is ready, I'll request review from you. |
…op bug Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
Fix failing smbjson unit tests: len_cor_max and dielectric_eq field mismatches
…fdtd into fixing-nfde-fdtdjson-mismatch
Contributor
Author
|
@copilot try to fix failing tests |
Contributor
|
@lmdiazangulo I've opened a new pull request, #328, to work on those changes. Once the pull request is ready, I'll request review from you. |
…test Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
Fix two CI test failures: wire probe nd index and unreliable MTLN integration test
Alberto-o
approved these changes
Mar 19, 2026
lmdiazangulo
added a commit
that referenced
this pull request
Mar 19, 2026
Merge pull request #298 from OpenSEMBA/fixing-nfde-fdtdjson-mismatch Fixing nfde and fdtdjson parsing mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #701 in EW Workbench
Fixes #286