58 major redesign by lmdiazangulo · Pull Request #60 · OpenSEMBA/tulip

lmdiazangulo · 2026-03-24T06:06:14Z

Closes #58

* Initial commit * Fixes test organization * Minor * token * token * Testing keys * Retrying * Adding tests to CI * Changing order * Fixing * Minor * minor2 * Minor3 * Fixing requirements * Fix test discovery * Cache fix * minor * Testing cache * cache

* Minor * token * token * Testing keys * Retrying * Adding tests to CI * Changing order * Fixing * Minor * minor2 * Minor3 * Fixing requirements * Fix test discovery * Cache fix * minor * Testing cache * cache * MInor * Minor

Entities not in physical groups are now deleted

Fixes issues when nested domains are present.

Dev

…e in output JSON

…pedance values

…d-information

Write shield transfer impedance information to tulip.out.json

lmdiazangulo · 2026-04-10T15:33:42Z

@copilot the windows action is failing. Can you fix it in a sub-PR?

Copilot · 2026-04-10T15:33:52Z

@lmdiazangulo I've opened a new pull request, #79, to work on those changes. Once the pull request is ready, I'll request review from you.

…s on Windows Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/a1affb13-bb96-462d-9153-cf7438218597 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Fix Windows CI: enable gmsh mesh module via x64-windows vcpkg triplet

lmdiazangulo · 2026-04-10T18:17:39Z

@copilot it's still failing. Can you fix it?

Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/23b88cea-70e6-4f8b-bd19-41609a5927af Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot · 2026-04-10T18:19:36Z

@copilot it's still failing. Can you fix it?

Fixed in 3c23268. The Windows CI was failing because gmsh's MSVC build hit C1128 ("number of sections exceeded object file format limit"). Added /bigobj compiler flag for the gmsh port in triplets/x64-windows.cmake.

lmdiazangulo · 2026-04-10T21:00:25Z

@copilot it is still failing. Can you fix it?

…n Field.cpp Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/5f785b6a-7673-487b-bb5c-b3b997670f78 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot · 2026-04-10T21:02:42Z

@copilot it is still failing. Can you fix it?

Fixed in 71a53d5. The new error was C2664 in gmsh's Field.cpp — it calls CreateProcess with a char* argument, but the build defines -DUNICODE which maps CreateProcess to CreateProcessW (requiring LPWSTR). Added /UUNICODE /U_UNICODE to the gmsh compiler flags in triplets/x64-windows.cmake to undefine those macros.

lmdiazangulo · 2026-04-11T03:28:14Z

@copilot windows test is failing, can you increase the error tolerance in the only failing test a little bit?

…ar for Windows platform differences Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/d2181fc1-d4bb-4ae4-ac05-24e9ac0382b8 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot · 2026-04-11T03:31:29Z

@copilot windows test is failing, can you increase the error tolerance in the only failing test a little bit?

Done in f9565a9. The failing test DriverTest.realistic_case_with_dielectrics_multipolar had tight relative error tolerances (1.5%–5%) that Windows' gmsh mesh slightly exceeded due to platform-specific meshing differences. Doubled all 8 tolerance thresholds to accommodate this.

lmdiazangulo added 30 commits August 9, 2023 17:23

Testing cache

4b20844

cache

6c35923

Adds Github action for testing

92ce0b5

* Initial commit * Fixes test organization * Minor * token * token * Testing keys * Retrying * Adding tests to CI * Changing order * Fixing * Minor * minor2 * Minor3 * Fixing requirements * Fix test discovery * Cache fix * minor * Testing cache * cache

Merge branch 'master' of github.com:lmdiazangulo/step2gmsh

d954d2e

Minor for status badge

15793cb

Removes unused workflow

b14b729

MInor

788177e

[WIP] Adding open boundary meshing.

e35aa36

Merge branch 'master' into dev

2ca396c

MInor

445a73b

Minor

4172148

Dev (#3)

8cbb706

* Minor * token * token * Testing keys * Retrying * Adding tests to CI * Changing order * Fixing * Minor * minor2 * Minor3 * Fixing requirements * Fix test discovery * Cache fix * minor * Testing cache * cache * MInor * Minor

Removes entities not in physical groups

75ed7c3

Removes size max from default options

b4d7354

Enlarges boundary for open problem

23a609f

Merge pull request #4 from lmdiazangulo/dev

d3e7e50

Entities not in physical groups are now deleted

[WIP] Implementing subdomains

05f04a4

Improving tests to check correct number of entities

41695bb

Debugging

6a0b53a

All test pass

f904a4b

Fixes issue with vacuum domain

cee6c8e

Merge pull request #5 from lmdiazangulo/dev

a6e2472

Fixes issues when nested domains are present.

Adds two wires open case

bb0572b

Adds semi-open problem meshing capability.

205960c

Removal of entities not in physical group is now recursive

58b1724

Boundaries are now ensured to be part of vacuum manifold.

e1ca7bc

Minor in actions

12aa10d

Merge pull request #6 from OpenSEMBA/dev

4473b7f

Dev

Minor changes in names

af2b85f

Fix issue w/ open boundaries in semi-open case

365a8d8

lmdiazangulo and others added 7 commits April 10, 2026 15:10

Update nested shield test to include resistance and transfer impedanc…

265f45a

…e in output JSON

Minor

f16d68c

enables opemp in driver

4f6eb45

Enhance nested shield test to copy step file and validate transfer im…

c204c60

…pedance values

Merge remote-tracking branch 'origin/58-major-redesign' into 75-shiel…

02d08ad

…d-information

Adds isShield in adapted files

e98110c

Merge pull request #77 from OpenSEMBA/75-shield-information

be8bdf2

Write shield transfer impedance information to tulip.out.json

Initial plan

7a02e46

Copilot AI mentioned this pull request Apr 10, 2026

Fix Windows CI: enable gmsh mesh module via x64-windows vcpkg triplet #79

Merged

Copilot AI and others added 2 commits April 10, 2026 15:46

Add x64-windows vcpkg triplet with ENABLE_MESH=ON to fix adapter test…

21b2a6f

…s on Windows Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/a1affb13-bb96-462d-9153-cf7438218597 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Merge pull request #79 from OpenSEMBA/copilot/sub-pr-60-again

5dc0af6

Fix Windows CI: enable gmsh mesh module via x64-windows vcpkg triplet

Copilot started work on behalf of lmdiazangulo April 10, 2026 18:17 View session

fix: add /bigobj flag for gmsh vcpkg build on Windows to fix C1128 error

3c23268

Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/23b88cea-70e6-4f8b-bd19-41609a5927af Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot finished work on behalf of lmdiazangulo April 10, 2026 18:20

Copilot started work on behalf of lmdiazangulo April 10, 2026 21:00 View session

fix: undefine UNICODE macros for gmsh MSVC build to fix C2664 error i…

71a53d5

…n Field.cpp Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/5f785b6a-7673-487b-bb5c-b3b997670f78 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot finished work on behalf of lmdiazangulo April 10, 2026 21:03

Copilot started work on behalf of lmdiazangulo April 11, 2026 03:28 View session

test: increase tolerances in realistic_case_with_dielectrics_multipol…

f9565a9

…ar for Windows platform differences Agent-Logs-Url: https://github.com/OpenSEMBA/tulip/sessions/d2181fc1-d4bb-4ae4-ac05-24e9ac0382b8 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>

Copilot finished work on behalf of lmdiazangulo April 11, 2026 03:32

adrianarce-elemwave approved these changes Apr 15, 2026

View reviewed changes

lmdiazangulo merged commit 8d93cac into dev Apr 15, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

58 major redesign#60

58 major redesign#60
lmdiazangulo merged 268 commits intodevfrom
58-major-redesign

lmdiazangulo commented Mar 24, 2026 •

edited

Loading

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 11, 2026

Uh oh!

Copilot AI commented Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lmdiazangulo commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

lmdiazangulo commented Apr 11, 2026

Uh oh!

Copilot AI commented Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lmdiazangulo commented Mar 24, 2026 •

edited

Loading