Fix CI issues (#3501 fallout)#3630
Merged
Merged
Conversation
"error: storing the address of local variable ‘from_hdr’ in ‘dummy_msg.headers’"
… format
DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_EPOLL -DHAVE_SIGIO_RT -DHAVE_SELECT -DUNIT_TESTS -Wno-deprecated-declarations -I/usr/include/libxml2 -c cpl_run.c -o cpl_run.o
In file included from ../../mem/mem.h:30,
from cpl_run.c:35:
cpl_switches.h: In function ‘run_address_switch’:
../../mem/../dprint.h:71:36: error: ‘%.*s’ directive argument is null [-Werror=format-overflow=]
71 | #define DP_PREFIX (char *)"%s [%d] "
| ^~~~~~~~~~
cpl_switches.h:192:41: note: in expansion of macro ‘LM_DBG’
192 | LM_DBG("extracted val. is <%.*s>\n",
| ^~~~~~
transformations.c: In function ‘tr_eval_sdp’:
transformations.c:1761:70: error: ‘media.len’ may be used uninitialized [-Werror=maybe-uninitialized]
1761 | if ((media.s != NULL && stream->media.len == media.len &&
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sqlops_impl.c: In function ‘ops_sql_api_insert’:
sqlops_impl.c:910:12: error: ‘Jcols’ may be used uninitialized [-Werror=maybe-uninitialized]
910 | if (Jcols) cJSON_Delete(Jcols);
| ^
Contributor
Author
|
Some unrelated network-transient failure: |
liviuchircu
approved these changes
Apr 22, 2025
Member
liviuchircu
left a comment
liviuchircu
left a comment
There was a problem hiding this comment.
LGTM -- lots of sensible fixes, let's get all of these merged. Good work, @sobomax!
NormB
pushed a commit
to NormB/opensips
that referenced
this pull request
May 9, 2026
Fix CI issues (OpenSIPS#3501 fallout)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI issues caused by the merge of #3501.
Details
There were some CI issues related to addition of ubuntu 24.04 and the fact that GHCR images are not shared publicly by the OpenSIPS project.
Solution
Typo is fixed, some gcc-1[34] errors are fixes. I also think addressed some issue with undue slowness of the arm64 clang build on ubuntu specifically. Somehow it takes 10x time compared to other emulated architectures, suspected use of some advanced instructions that are not very well emulated. The virtual "CPU" has been "downgraded" to the lowest possible arm64 variant, which seems to bring arm64/ubuntu build times back in line.